Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Column pruning failed when groupby by multi series #708

Merged

Conversation

ChengjieLi28
Copy link
Contributor

What do these changes do?

Related issue number

Fixes #688

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the bug Something isn't working label Sep 20, 2023
@XprobeBot XprobeBot added this to the v0.6.2 milestone Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #708 (98f9621) into main (f16df9d) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #708      +/-   ##
==========================================
- Coverage   93.53%   93.50%   -0.03%     
==========================================
  Files        1025     1025              
  Lines       79353    79354       +1     
  Branches    16440    16441       +1     
==========================================
- Hits        74220    74200      -20     
- Misses       3453     3465      +12     
- Partials     1680     1689       +9     
Flag Coverage Δ
unittests 93.39% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...l/tileable/column_pruning/input_column_selector.py 97.26% <100.00%> (+0.01%) ⬆️

... and 14 files with indirect coverage changes

Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit fe7caba into xorbitsai:main Sep 20, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Column pruning failed
3 participants