Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHORE: Deprecate downcast in fillna #705

Merged

Conversation

ChengjieLi28
Copy link
Contributor

@ChengjieLi28 ChengjieLi28 commented Sep 19, 2023

What do these changes do?

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.6.2 milestone Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #705 (b990ca5) into main (bc0c60c) will increase coverage by 11.02%.
The diff coverage is 86.66%.

@@             Coverage Diff             @@
##             main     #705       +/-   ##
===========================================
+ Coverage   82.50%   93.52%   +11.02%     
===========================================
  Files        1025     1025               
  Lines       79377    79374        -3     
  Branches    16443    16443               
===========================================
+ Hits        65491    74237     +8746     
+ Misses      11627     3448     -8179     
+ Partials     2259     1689      -570     
Flag Coverage Δ
unittests 93.42% <86.66%> (+11.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ython/xorbits/_mars/dataframe/base/value_counts.py 85.08% <50.00%> (+30.62%) ⬆️
python/xorbits/_mars/dataframe/hash_utils.py 69.23% <66.66%> (+24.40%) ⬆️
python/xorbits/_mars/dataframe/groupby/fill.py 100.00% <100.00%> (+63.95%) ⬆️
python/xorbits/_mars/dataframe/missing/fillna.py 97.31% <100.00%> (+74.38%) ⬆️

... and 165 files with indirect coverage changes

@XprobeBot XprobeBot modified the milestones: v0.6.2, v0.6.3 Sep 20, 2023
aresnow1
aresnow1 previously approved these changes Sep 21, 2023
Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aresnow1 aresnow1 merged commit 4132deb into xorbitsai:main Sep 21, 2023
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants