Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes remote attachments testing in example app #558

Merged
merged 6 commits into from
Dec 9, 2024

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Dec 7, 2024

Revives and exposes commands for remote attachment testing from previous work #85

See new README instructions:

If testing the remote attachment content type, run (from example directory):

yarn run upload:up

If running on andoid also run:

adb reverse tcp:8443 tcp:8443
image

@cameronvoell cameronvoell requested review from a team as code owners December 7, 2024 00:19
Copy link

changeset-bot bot commented Dec 7, 2024

⚠️ No Changeset found

Latest commit: 2eb0bbd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@nplasterer nplasterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about bringing this test back from the legacy branch as well?

https://github.com/xmtp/xmtp-react-native/blob/xmtp-legacy/example/src/tests/tests.ts#L686-L773

I think a few tests from that file are probably still relevant even though I removed the whole file in the upgrade.

@cameronvoell cameronvoell merged commit 4a20699 into main Dec 9, 2024
5 of 6 checks passed
@cameronvoell cameronvoell deleted the cv/example-app-fix-remote-attachment branch December 9, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants