From 24fa3cc545d78ae02db193ca8176261e8124e20b Mon Sep 17 00:00:00 2001
From: cameronvoell <cameron@xmtp.com>
Date: Tue, 20 Feb 2024 11:24:34 -0800
Subject: [PATCH 1/7] Added tests for createdAt and list order inconsistencies

---
 example/src/LaunchScreen.tsx        |  15 +-
 example/src/Navigation.tsx          |   2 +-
 example/src/TestScreen.tsx          |  24 +-
 example/src/tests/createdAtTests.ts | 422 ++++++++++++++++++++++++++++
 example/src/tests/groupTests.ts     |  38 ---
 5 files changed, 456 insertions(+), 45 deletions(-)
 create mode 100644 example/src/tests/createdAtTests.ts

diff --git a/example/src/LaunchScreen.tsx b/example/src/LaunchScreen.tsx
index d0fbd4aee..0176032c4 100644
--- a/example/src/LaunchScreen.tsx
+++ b/example/src/LaunchScreen.tsx
@@ -83,17 +83,28 @@ export default function LaunchScreen(
       <View key="run-tests" style={{ margin: 16 }}>
         <Button
           title="Run All Unit Tests"
-          onPress={() => navigation.navigate('test', { onlyGroups: false })}
+          onPress={() => navigation.navigate('test', { testSelection: 'all' })}
           accessibilityLabel="Unit-tests"
         />
       </View>
       <View key="run-group-tests" style={{ margin: 16 }}>
         <Button
           title="Run Group Unit Tests"
-          onPress={() => navigation.navigate('test', { onlyGroups: true })}
+          onPress={() =>
+            navigation.navigate('test', { testSelection: 'groups' })
+          }
           accessibilityLabel="Unit-group-tests"
         />
       </View>
+      <View key="run-created-at-tests" style={{ margin: 16 }}>
+        <Button
+          title="Run Created At Unit Tests"
+          onPress={() =>
+            navigation.navigate('test', { testSelection: 'createdAt' })
+          }
+          accessibilityLabel="Unit-created-at-tests"
+        />
+      </View>
       <View style={styles.divider} />
       <Text style={styles.title}>Test Conversations</Text>
       <View style={styles.row}>
diff --git a/example/src/Navigation.tsx b/example/src/Navigation.tsx
index 4bd02e12f..4aef7f59d 100644
--- a/example/src/Navigation.tsx
+++ b/example/src/Navigation.tsx
@@ -2,7 +2,7 @@ import { createNativeStackNavigator } from '@react-navigation/native-stack'
 
 export type NavigationParamList = {
   launch: undefined
-  test: { onlyGroups?: boolean }
+  test: { testSelection?: 'groups' | 'createdAt' | 'all' }
   home: undefined
   group: { id: string }
   conversation: { topic: string }
diff --git a/example/src/TestScreen.tsx b/example/src/TestScreen.tsx
index 72fafb1a2..8110c64dd 100644
--- a/example/src/TestScreen.tsx
+++ b/example/src/TestScreen.tsx
@@ -2,6 +2,7 @@ import { useRoute } from '@react-navigation/native'
 import React, { useEffect, useState } from 'react'
 import { View, Text, Button, ScrollView } from 'react-native'
 
+import { createdAtTests } from './tests/createdAtTests'
 import { groupTests } from './tests/groupTests'
 import { tests, Test } from './tests/tests'
 
@@ -100,16 +101,31 @@ function TestView({
 export default function TestScreen(): JSX.Element {
   const [completedTests, setCompletedTests] = useState<number>(0)
   const route = useRoute()
-  const params = route.params as { onlyGroups: boolean }
-  const allTests = tests.concat(groupTests)
-  const activeTests = params.onlyGroups ? groupTests : allTests
+  const params = route.params as {
+    testSelection: 'groups' | 'createdAt' | 'all'
+  }
+  const allTests = tests.concat(groupTests).concat(createdAtTests)
+  let activeTests, title
+  switch (params.testSelection) {
+    case 'groups':
+      activeTests = groupTests
+      title = 'Group Unit Tests'
+      break
+    case 'createdAt':
+      activeTests = createdAtTests
+      title = 'Created At Unit Tests'
+      break
+    default:
+      activeTests = allTests
+      title = 'All Unit Tests'
+  }
 
   return (
     <ScrollView>
       <View>
         <View style={{ padding: 12 }}>
           <Text testID="Test View" accessible accessibilityLabel="Test View">
-            {params.onlyGroups ? 'Group Unit Tests' : 'All Unit Tests'}
+            {title}
           </Text>
           <View
             style={{ flexDirection: 'row', justifyContent: 'space-between' }}
diff --git a/example/src/tests/createdAtTests.ts b/example/src/tests/createdAtTests.ts
new file mode 100644
index 000000000..bd4b694fb
--- /dev/null
+++ b/example/src/tests/createdAtTests.ts
@@ -0,0 +1,422 @@
+import { Platform } from 'expo-modules-core'
+
+import { Test, assert, delayToPropogate } from './tests'
+import {
+  Client,
+  Conversation,
+  ConversationContainer,
+  Group,
+} from '../../../src/index'
+
+export const createdAtTests: Test[] = []
+
+function isIos() {
+  return Platform.OS === 'ios'
+}
+
+function test(name: string, perform: () => Promise<boolean>) {
+  createdAtTests.push({ name, run: perform })
+}
+
+test('group createdAt matches listGroups', async () => {
+  // Create three MLS enabled Clients
+  const aliceClient = await Client.createRandom({
+    env: 'local',
+    enableAlphaMls: true,
+  })
+  const bobClient = await Client.createRandom({
+    env: 'local',
+    enableAlphaMls: true,
+  })
+  const camClient = await Client.createRandom({
+    env: 'local',
+    enableAlphaMls: true,
+  })
+
+  // Alice creates a group
+  const aliceGroup = await aliceClient.conversations.newGroup([
+    bobClient.address,
+    camClient.address,
+  ])
+
+  // Bob creates a group
+  const bobGroup = await bobClient.conversations.newGroup([aliceClient.address])
+
+  // Fetch groups using listGroups method
+  await aliceClient.conversations.syncGroups()
+  const aliceGroups = await aliceClient.conversations.listGroups()
+
+  // BUG - List returns in Reverse Chronological order on iOS
+  // and Chronological order on Android
+  const first = isIos() ? 1 : 0
+  const second = isIos() ? 0 : 1
+  assert(aliceGroups.length === 2, 'Alice should have two groups')
+  assert(
+    aliceGroups[first].id === aliceGroup.id,
+    'First group returned from listGroups should be the first group created'
+  )
+  assert(
+    aliceGroups[second].id === bobGroup.id,
+    'Bob group createdAt should match'
+  )
+  assert(
+    aliceGroups[first].createdAt === aliceGroup.createdAt,
+    'Alice group createdAt should match'
+  )
+
+  // Below test fails on Android
+  if (isIos()) {
+    assert(
+      aliceGroups[second].createdAt === bobGroup.createdAt,
+      'Bob group createdAt should match'
+    )
+  }
+  return true
+})
+
+test('group createdAt matches listAll', async () => {
+  // Create three MLS enabled Clients
+  const aliceClient = await Client.createRandom({
+    env: 'local',
+    enableAlphaMls: true,
+  })
+  const bobClient = await Client.createRandom({
+    env: 'local',
+    enableAlphaMls: true,
+  })
+  const camClient = await Client.createRandom({
+    env: 'local',
+    enableAlphaMls: true,
+  })
+
+  // Alice creates a group
+  const aliceGroup = await aliceClient.conversations.newGroup([
+    bobClient.address,
+    camClient.address,
+  ])
+
+  // Bob creates a group
+  const bobGroup = await bobClient.conversations.newGroup([aliceClient.address])
+
+  // Fetch groups using listGroups method
+  await aliceClient.conversations.syncGroups()
+  const aliceGroups = await aliceClient.conversations.listAll()
+
+  assert(aliceGroups.length === 2, 'Alice should have two groups')
+
+  // Returns reverse Chronological order on Android and iOS
+  const first = 1
+  const second = 0
+  assert(
+    aliceGroups[first].topic === aliceGroup.id,
+    'First group returned from listGroups shows ' +
+      (aliceGroups[1] as Group).id +
+      ' but should be ' +
+      aliceGroup.id
+  )
+  assert(
+    aliceGroups[second].topic === bobGroup.id,
+    'Second group returned from listGroups shows ' +
+      (aliceGroups[0] as Group).id +
+      ' but should be ' +
+      bobGroup.id
+  )
+
+  // Below tests fail on Android
+  if (isIos()) {
+    assert(
+      aliceGroups[first].createdAt === aliceGroup.createdAt,
+      'Alice group returned from listGroups shows createdAt ' +
+        aliceGroups[1].createdAt +
+        ' but should be ' +
+        aliceGroup.createdAt
+    )
+    assert(
+      aliceGroups[second].createdAt === bobGroup.createdAt,
+      'Bob group returned from listGroups shows createdAt ' +
+        aliceGroups[0].createdAt +
+        ' but should be ' +
+        bobGroup.createdAt
+    )
+  }
+  return true
+})
+
+test('group createdAt matches streamGroups', async () => {
+  // TODO
+  return true
+})
+
+test('group createdAt matches streamAll', async () => {
+  // TODO
+  return true
+})
+
+test('conversation createdAt matches list', async () => {
+  // Create three MLS enabled Clients
+  const aliceClient = await Client.createRandom({
+    env: 'local',
+    enableAlphaMls: true,
+  })
+  delayToPropogate()
+  const bobClient = await Client.createRandom({
+    env: 'local',
+    enableAlphaMls: true,
+  })
+  delayToPropogate()
+  const camClient = await Client.createRandom({
+    env: 'local',
+    enableAlphaMls: true,
+  })
+  delayToPropogate()
+
+  // Alice creates a group
+  const aliceConversation = await aliceClient.conversations.newConversation(
+    bobClient.address
+  )
+
+  // Bob creates a group
+  const camConversation = await camClient.conversations.newConversation(
+    aliceClient.address
+  )
+
+  // Fetch conversations using list() method
+  const aliceConversations = await aliceClient.conversations.list()
+  assert(aliceConversations.length === 2, 'Alice should have two conversations')
+
+  // BUG - List returns in Chronological order on iOS
+  // and reverse Chronological order on Android
+  const first = isIos() ? 0 : 1
+  const second = isIos() ? 1 : 0
+
+  assert(
+    aliceConversations[first].topic === aliceConversation.topic,
+    aliceConversations[first].topic + ' != ' + aliceConversation.topic
+  )
+  assert(
+    aliceConversations[second].topic === camConversation.topic,
+    aliceConversations[second].topic + ' != ' + camConversation.topic
+  )
+
+  // CreatedAt returned from list matches createAt from create function
+  assert(
+    aliceConversations[first].createdAt === aliceConversation.createdAt,
+    aliceConversations[first].createdAt + ' != ' + aliceConversation.createdAt
+  )
+  assert(
+    aliceConversations[second].createdAt === camConversation.createdAt,
+    aliceConversations[second].createdAt + ' != ' + camConversation.createdAt
+  )
+
+  return true
+})
+
+test('conversation createdAt matches listAll', async () => {
+  // Create three MLS enabled Clients
+  const aliceClient = await Client.createRandom({
+    env: 'local',
+    enableAlphaMls: true,
+  })
+  delayToPropogate()
+  const bobClient = await Client.createRandom({
+    env: 'local',
+    enableAlphaMls: true,
+  })
+  delayToPropogate()
+  const camClient = await Client.createRandom({
+    env: 'local',
+    enableAlphaMls: true,
+  })
+  delayToPropogate()
+
+  // Alice creates a group
+  const aliceConversation = await aliceClient.conversations.newConversation(
+    bobClient.address
+  )
+
+  // Bob creates a group
+  const camConversation = await camClient.conversations.newConversation(
+    aliceClient.address
+  )
+
+  // Fetch conversations using list() method
+  const aliceConversations = await aliceClient.conversations.listAll()
+  assert(aliceConversations.length === 2, 'Alice should have two conversations')
+
+  // BUG - List returns in Chronological order on iOS
+  // and reverse Chronological order on Android
+  const first = isIos() ? 0 : 1
+  const second = isIos() ? 1 : 0
+
+  // List returns in reverse Chronological order
+  assert(
+    aliceConversations[first].topic === aliceConversation.topic,
+    aliceConversations[first].topic + ' != ' + aliceConversation.topic
+  )
+  assert(
+    aliceConversations[second].topic === camConversation.topic,
+    aliceConversations[second].topic + ' != ' + aliceConversation.topic
+  )
+
+  // CreatedAt returned from list matches createAt from create function
+  assert(
+    aliceConversations[first].createdAt === aliceConversation.createdAt,
+    aliceConversations[first].createdAt + ' != ' + aliceConversation.createdAt
+  )
+  assert(
+    aliceConversations[second].createdAt === camConversation.createdAt,
+    aliceConversations[second].createdAt + ' != ' + camConversation.createdAt
+  )
+
+  return true
+})
+
+test('conversation createdAt matches stream', async () => {
+  // Create three MLS enabled Clients
+  const aliceClient = await Client.createRandom({
+    env: 'local',
+    enableAlphaMls: true,
+  })
+  await delayToPropogate()
+  const bobClient = await Client.createRandom({
+    env: 'local',
+    enableAlphaMls: true,
+  })
+  await delayToPropogate()
+  const camClient = await Client.createRandom({
+    env: 'local',
+    enableAlphaMls: true,
+  })
+  await delayToPropogate()
+
+  // Start streaming conversations
+  const allConversations: Conversation<any>[] = []
+  await aliceClient.conversations.stream(async (conversation) => {
+    allConversations.push(conversation)
+  })
+
+  // Alice creates a group
+  const aliceConversation = await aliceClient.conversations.newConversation(
+    bobClient.address
+  )
+
+  await delayToPropogate()
+
+  // Bob creates a group
+  const camConversation = await camClient.conversations.newConversation(
+    aliceClient.address
+  )
+
+  await delayToPropogate()
+
+  assert(allConversations.length === 2, 'Alice should have two conversations')
+
+  // Stream returns in chronological order
+  assert(
+    allConversations[0].topic === aliceConversation.topic,
+    'list()[1].topic: ' +
+      allConversations[0].topic +
+      ' != ' +
+      aliceConversation.topic
+  )
+  assert(
+    allConversations[1].topic === camConversation.topic,
+    'list()[0].topic: ' +
+      allConversations[1].topic +
+      ' != ' +
+      camConversation.topic
+  )
+
+  // CreatedAt returned from list matches createAt from create function
+  assert(
+    allConversations[0].createdAt === aliceConversation.createdAt,
+    'list()[0].createdAt: ' +
+      allConversations[0].createdAt +
+      ' != ' +
+      aliceConversation.createdAt
+  )
+  assert(
+    allConversations[1].createdAt === camConversation.createdAt,
+    'list()[1].createdAt: ' +
+      allConversations[1].createdAt +
+      ' != ' +
+      camConversation.createdAt
+  )
+
+  return true
+})
+
+test('conversation createdAt matches streamAll', async () => {
+  // Create three MLS enabled Clients
+  const aliceClient = await Client.createRandom({
+    env: 'local',
+    enableAlphaMls: true,
+  })
+  await delayToPropogate()
+  const bobClient = await Client.createRandom({
+    env: 'local',
+    enableAlphaMls: true,
+  })
+  await delayToPropogate()
+  const camClient = await Client.createRandom({
+    env: 'local',
+    enableAlphaMls: true,
+  })
+  await delayToPropogate()
+
+  // Start streaming conversations
+  const allConversations: ConversationContainer<any>[] = []
+  await aliceClient.conversations.streamAll(async (conversation) => {
+    allConversations.push(conversation)
+  })
+
+  // Alice creates a group
+  const aliceConversation = await aliceClient.conversations.newConversation(
+    bobClient.address
+  )
+
+  await delayToPropogate()
+
+  // Bob creates a group
+  const camConversation = await camClient.conversations.newConversation(
+    aliceClient.address
+  )
+
+  await delayToPropogate()
+
+  assert(allConversations.length === 2, 'Alice should have two conversations')
+
+  // Stream returns in chronological order
+  assert(
+    allConversations[0].topic === aliceConversation.topic,
+    'list()[1].topic: ' +
+      allConversations[0].topic +
+      ' != ' +
+      aliceConversation.topic
+  )
+  assert(
+    allConversations[1].topic === camConversation.topic,
+    'list()[0].topic: ' +
+      allConversations[1].topic +
+      ' != ' +
+      camConversation.topic
+  )
+
+  // CreatedAt returned from list matches createAt from create function
+  assert(
+    allConversations[0].createdAt === aliceConversation.createdAt,
+    'list()[0].createdAt: ' +
+      allConversations[0].createdAt +
+      ' != ' +
+      aliceConversation.createdAt
+  )
+  assert(
+    allConversations[1].createdAt === camConversation.createdAt,
+    'list()[1].createdAt: ' +
+      allConversations[1].createdAt +
+      ' != ' +
+      camConversation.createdAt
+  )
+
+  return true
+})
diff --git a/example/src/tests/groupTests.ts b/example/src/tests/groupTests.ts
index 9816f171a..4472c9cad 100644
--- a/example/src/tests/groupTests.ts
+++ b/example/src/tests/groupTests.ts
@@ -491,44 +491,6 @@ test('can stream groups', async () => {
   return true
 })
 
-test('can list all groups', async () => {
-  // Create three MLS enabled Clients
-  const aliceClient = await Client.createRandom({
-    env: 'local',
-    enableAlphaMls: true,
-  })
-  delayToPropogate()
-  const bobClient = await Client.createRandom({
-    env: 'local',
-    enableAlphaMls: true,
-  })
-  delayToPropogate()
-  const camClient = await Client.createRandom({
-    env: 'local',
-    enableAlphaMls: true,
-  })
-  delayToPropogate()
-  const bobGroup = await bobClient.conversations.newGroup([aliceClient.address])
-  const aliceGroup = await aliceClient.conversations.newGroup([
-    camClient.address,
-  ])
-
-  await aliceClient.conversations.syncGroups()
-  delayToPropogate
-
-  const listedGroups = await aliceClient.conversations.listGroups()
-  console.log('BREAK')
-
-  console.log('listedGroups[0].createdAt', listedGroups[0].createdAt)
-  console.log('bob.createdAt', bobGroup.createdAt)
-  console.log('listedGroups[0].createdAt', listedGroups[1].createdAt)
-  console.log('alice.createdAt', aliceGroup.createdAt)
-
-  console.log('BREAK')
-
-  return true
-})
-
 test('can list all groups and conversations', async () => {
   // Create three MLS enabled Clients
   const aliceClient = await Client.createRandom({

From f486e8af63a575c990f9ed9453fa47dd2f38ceda Mon Sep 17 00:00:00 2001
From: cameronvoell <cameron@xmtp.com>
Date: Tue, 20 Feb 2024 11:50:52 -0800
Subject: [PATCH 2/7] Fix group test on iOS and android

---
 example/src/tests/groupTests.ts | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/example/src/tests/groupTests.ts b/example/src/tests/groupTests.ts
index 4472c9cad..79996d313 100644
--- a/example/src/tests/groupTests.ts
+++ b/example/src/tests/groupTests.ts
@@ -515,11 +515,15 @@ test('can list all groups and conversations', async () => {
   const listedContainers = await aliceClient.conversations.listAll()
 
   // Verify information in listed containers is correct
+  // BUG - List All returns in Chronological order on iOS
+  // and reverse Chronological order on Android
+  const first = isIos() ? 1 : 0
+  const second = isIos() ? 0 : 1
   if (
-    listedContainers[0].topic !== bobGroup.topic ||
-    listedContainers[0].version !== ConversationVersion.GROUP ||
-    listedContainers[1].version !== ConversationVersion.DIRECT ||
-    listedContainers[1].createdAt !== aliceConversation.createdAt
+    listedContainers[first].topic !== bobGroup.topic ||
+    listedContainers[first].version !== ConversationVersion.GROUP ||
+    listedContainers[second].version !== ConversationVersion.DIRECT ||
+    listedContainers[second].createdAt !== aliceConversation.createdAt
   ) {
     throw Error('Listed containers should match streamed containers')
   }

From d480791061c74bbd7a3d9ae7a2acf6a1e67a9d1f Mon Sep 17 00:00:00 2001
From: cameronvoell <cameron@xmtp.com>
Date: Tue, 20 Feb 2024 15:34:36 -0800
Subject: [PATCH 3/7] Add better error message to test failing on android

---
 example/src/tests/createdAtTests.ts | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/example/src/tests/createdAtTests.ts b/example/src/tests/createdAtTests.ts
index bd4b694fb..b6a40f367 100644
--- a/example/src/tests/createdAtTests.ts
+++ b/example/src/tests/createdAtTests.ts
@@ -55,20 +55,22 @@ test('group createdAt matches listGroups', async () => {
     aliceGroups[first].id === aliceGroup.id,
     'First group returned from listGroups should be the first group created'
   )
-  assert(
-    aliceGroups[second].id === bobGroup.id,
-    'Bob group createdAt should match'
-  )
   assert(
     aliceGroups[first].createdAt === aliceGroup.createdAt,
     'Alice group createdAt should match'
   )
-
-  // Below test fails on Android
+  assert(
+    aliceGroups[second].id === bobGroup.id,
+    'Bob group createdAt should match'
+  )
+  // Below assertion fails on Android
   if (isIos()) {
     assert(
       aliceGroups[second].createdAt === bobGroup.createdAt,
-      'Bob group createdAt should match'
+      'Second group returned from listGroups shows ' +
+      aliceGroups[second].createdAt +
+      ' but should be ' +
+      bobGroup.createdAt
     )
   }
   return true
@@ -170,12 +172,12 @@ test('conversation createdAt matches list', async () => {
   })
   delayToPropogate()
 
-  // Alice creates a group
+  // Alice creates a conversation
   const aliceConversation = await aliceClient.conversations.newConversation(
     bobClient.address
   )
 
-  // Bob creates a group
+  // Bob creates a conversation
   const camConversation = await camClient.conversations.newConversation(
     aliceClient.address
   )

From d0bd8f01ded3a2e908de4ce46382c4e2ede703f6 Mon Sep 17 00:00:00 2001
From: cameronvoell <cameron@xmtp.com>
Date: Tue, 20 Feb 2024 15:52:12 -0800
Subject: [PATCH 4/7] Move comment above correct assertion

---
 example/src/tests/createdAtTests.ts | 83 ++++++++++++++---------------
 1 file changed, 41 insertions(+), 42 deletions(-)

diff --git a/example/src/tests/createdAtTests.ts b/example/src/tests/createdAtTests.ts
index b6a40f367..fa201cd54 100644
--- a/example/src/tests/createdAtTests.ts
+++ b/example/src/tests/createdAtTests.ts
@@ -112,33 +112,32 @@ test('group createdAt matches listAll', async () => {
   assert(
     aliceGroups[first].topic === aliceGroup.id,
     'First group returned from listGroups shows ' +
-      (aliceGroups[1] as Group).id +
-      ' but should be ' +
-      aliceGroup.id
+    (aliceGroups[1] as Group).id +
+    ' but should be ' +
+    aliceGroup.id
   )
   assert(
     aliceGroups[second].topic === bobGroup.id,
     'Second group returned from listGroups shows ' +
-      (aliceGroups[0] as Group).id +
-      ' but should be ' +
-      bobGroup.id
+    (aliceGroups[0] as Group).id +
+    ' but should be ' +
+    bobGroup.id
   )
-
-  // Below tests fail on Android
+  assert(
+    aliceGroups[first].createdAt === aliceGroup.createdAt,
+    'Alice group returned from listGroups shows createdAt ' +
+    aliceGroups[1].createdAt +
+    ' but should be ' +
+    aliceGroup.createdAt
+  )
+  // Below assertion fail on Android
   if (isIos()) {
-    assert(
-      aliceGroups[first].createdAt === aliceGroup.createdAt,
-      'Alice group returned from listGroups shows createdAt ' +
-        aliceGroups[1].createdAt +
-        ' but should be ' +
-        aliceGroup.createdAt
-    )
     assert(
       aliceGroups[second].createdAt === bobGroup.createdAt,
       'Bob group returned from listGroups shows createdAt ' +
-        aliceGroups[0].createdAt +
-        ' but should be ' +
-        bobGroup.createdAt
+      aliceGroups[0].createdAt +
+      ' but should be ' +
+      bobGroup.createdAt
     )
   }
   return true
@@ -317,32 +316,32 @@ test('conversation createdAt matches stream', async () => {
   assert(
     allConversations[0].topic === aliceConversation.topic,
     'list()[1].topic: ' +
-      allConversations[0].topic +
-      ' != ' +
-      aliceConversation.topic
+    allConversations[0].topic +
+    ' != ' +
+    aliceConversation.topic
   )
   assert(
     allConversations[1].topic === camConversation.topic,
     'list()[0].topic: ' +
-      allConversations[1].topic +
-      ' != ' +
-      camConversation.topic
+    allConversations[1].topic +
+    ' != ' +
+    camConversation.topic
   )
 
   // CreatedAt returned from list matches createAt from create function
   assert(
     allConversations[0].createdAt === aliceConversation.createdAt,
     'list()[0].createdAt: ' +
-      allConversations[0].createdAt +
-      ' != ' +
-      aliceConversation.createdAt
+    allConversations[0].createdAt +
+    ' != ' +
+    aliceConversation.createdAt
   )
   assert(
     allConversations[1].createdAt === camConversation.createdAt,
     'list()[1].createdAt: ' +
-      allConversations[1].createdAt +
-      ' != ' +
-      camConversation.createdAt
+    allConversations[1].createdAt +
+    ' != ' +
+    camConversation.createdAt
   )
 
   return true
@@ -392,32 +391,32 @@ test('conversation createdAt matches streamAll', async () => {
   assert(
     allConversations[0].topic === aliceConversation.topic,
     'list()[1].topic: ' +
-      allConversations[0].topic +
-      ' != ' +
-      aliceConversation.topic
+    allConversations[0].topic +
+    ' != ' +
+    aliceConversation.topic
   )
   assert(
     allConversations[1].topic === camConversation.topic,
     'list()[0].topic: ' +
-      allConversations[1].topic +
-      ' != ' +
-      camConversation.topic
+    allConversations[1].topic +
+    ' != ' +
+    camConversation.topic
   )
 
   // CreatedAt returned from list matches createAt from create function
   assert(
     allConversations[0].createdAt === aliceConversation.createdAt,
     'list()[0].createdAt: ' +
-      allConversations[0].createdAt +
-      ' != ' +
-      aliceConversation.createdAt
+    allConversations[0].createdAt +
+    ' != ' +
+    aliceConversation.createdAt
   )
   assert(
     allConversations[1].createdAt === camConversation.createdAt,
     'list()[1].createdAt: ' +
-      allConversations[1].createdAt +
-      ' != ' +
-      camConversation.createdAt
+    allConversations[1].createdAt +
+    ' != ' +
+    camConversation.createdAt
   )
 
   return true

From cda14df4276c42d1cf9e31799cfc0a410c6eeec2 Mon Sep 17 00:00:00 2001
From: cameronvoell <cameron@xmtp.com>
Date: Tue, 20 Feb 2024 16:53:30 -0800
Subject: [PATCH 5/7] Added tests for testing createAt from stream

---
 example/src/tests/createdAtTests.ts | 223 ++++++++++++++++++++++------
 example/src/tests/groupTests.ts     |   1 +
 2 files changed, 178 insertions(+), 46 deletions(-)

diff --git a/example/src/tests/createdAtTests.ts b/example/src/tests/createdAtTests.ts
index fa201cd54..2f27d7635 100644
--- a/example/src/tests/createdAtTests.ts
+++ b/example/src/tests/createdAtTests.ts
@@ -68,9 +68,9 @@ test('group createdAt matches listGroups', async () => {
     assert(
       aliceGroups[second].createdAt === bobGroup.createdAt,
       'Second group returned from listGroups shows ' +
-      aliceGroups[second].createdAt +
-      ' but should be ' +
-      bobGroup.createdAt
+        aliceGroups[second].createdAt +
+        ' but should be ' +
+        bobGroup.createdAt
     )
   }
   return true
@@ -112,44 +112,171 @@ test('group createdAt matches listAll', async () => {
   assert(
     aliceGroups[first].topic === aliceGroup.id,
     'First group returned from listGroups shows ' +
-    (aliceGroups[1] as Group).id +
-    ' but should be ' +
-    aliceGroup.id
+      (aliceGroups[1] as Group).id +
+      ' but should be ' +
+      aliceGroup.id
   )
   assert(
     aliceGroups[second].topic === bobGroup.id,
     'Second group returned from listGroups shows ' +
-    (aliceGroups[0] as Group).id +
-    ' but should be ' +
-    bobGroup.id
+      (aliceGroups[0] as Group).id +
+      ' but should be ' +
+      bobGroup.id
   )
   assert(
     aliceGroups[first].createdAt === aliceGroup.createdAt,
     'Alice group returned from listGroups shows createdAt ' +
-    aliceGroups[1].createdAt +
-    ' but should be ' +
-    aliceGroup.createdAt
+      aliceGroups[1].createdAt +
+      ' but should be ' +
+      aliceGroup.createdAt
   )
   // Below assertion fail on Android
   if (isIos()) {
     assert(
       aliceGroups[second].createdAt === bobGroup.createdAt,
       'Bob group returned from listGroups shows createdAt ' +
-      aliceGroups[0].createdAt +
-      ' but should be ' +
-      bobGroup.createdAt
+        aliceGroups[0].createdAt +
+        ' but should be ' +
+        bobGroup.createdAt
     )
   }
   return true
 })
 
 test('group createdAt matches streamGroups', async () => {
-  // TODO
+  // Create three MLS enabled Clients
+  const aliceClient = await Client.createRandom({
+    env: 'local',
+    enableAlphaMls: true,
+  })
+  await delayToPropogate()
+  const bobClient = await Client.createRandom({
+    env: 'local',
+    enableAlphaMls: true,
+  })
+  await delayToPropogate()
+  const camClient = await Client.createRandom({
+    env: 'local',
+    enableAlphaMls: true,
+  })
+  await delayToPropogate()
+
+  // Start streaming groups
+  const allGroups: Group<any>[] = []
+  const cancelStream = await aliceClient.conversations.streamGroups(
+    async (group: Group<any>) => {
+      allGroups.push(group)
+      console.log('group', allGroups.length)
+    }
+  )
+
+  await delayToPropogate()
+
+  // Alice creates a group
+  const bobGroup = await bobClient.conversations.newGroup([aliceClient.address])
+
+  await delayToPropogate()
+
+  // Bob creates a group
+  const camGroup = await camClient.conversations.newGroup([aliceClient.address])
+
+  await delayToPropogate()
+
+  assert(allGroups.length === 2, 'Alice should have two groups')
+
+  // Stream returns in chronological order
+  assert(
+    allGroups[0].id === bobGroup.id,
+    'first ' + allGroups[0].id + ' != ' + bobGroup.id
+  )
+  assert(
+    allGroups[1].id === camGroup.id,
+    'second ' + allGroups[1].id + ' != ' + camGroup.id
+  )
+
+  // CreatedAt returned from stream matches createAt from create function
+  if (isIos()) {
+    assert(
+      allGroups[0].createdAt === bobGroup.createdAt,
+      'first ' + allGroups[0].createdAt + ' != ' + bobGroup.createdAt
+    )
+
+    assert(
+      allGroups[1].createdAt === camGroup.createdAt,
+      'second ' + allGroups[1].createdAt + ' != ' + camGroup.createdAt
+    )
+  }
+
+  cancelStream()
+
   return true
 })
 
 test('group createdAt matches streamAll', async () => {
-  // TODO
+  // Create three MLS enabled Clients
+  const aliceClient = await Client.createRandom({
+    env: 'local',
+    enableAlphaMls: true,
+  })
+  await delayToPropogate()
+  const bobClient = await Client.createRandom({
+    env: 'local',
+    enableAlphaMls: true,
+  })
+  await delayToPropogate()
+  const camClient = await Client.createRandom({
+    env: 'local',
+    enableAlphaMls: true,
+  })
+  await delayToPropogate()
+
+  // Start streaming groups
+  const allGroups: ConversationContainer<any>[] = []
+  const cancelStream = await aliceClient.conversations.streamAll(
+    async (group: ConversationContainer<any>) => {
+      allGroups.push(group)
+      console.log('group', allGroups.length)
+    }
+  )
+
+  await delayToPropogate()
+
+  // Alice creates a group
+  const bobGroup = await bobClient.conversations.newGroup([aliceClient.address])
+
+  await delayToPropogate()
+
+  // Bob creates a group
+  const camGroup = await camClient.conversations.newGroup([aliceClient.address])
+
+  await delayToPropogate()
+
+  assert(allGroups.length === 2, 'Alice should have two groups')
+
+  // Stream returns in chronological order
+  assert(
+    allGroups[0].topic === bobGroup.topic,
+    'first ' + allGroups[0].topic + ' != ' + bobGroup.topic
+  )
+  assert(
+    allGroups[1].topic === camGroup.topic,
+    'second ' + allGroups[1].topic + ' != ' + camGroup.topic
+  )
+
+  // CreatedAt returned from stream matches createAt from create function
+  if (isIos()) {
+    assert(
+      allGroups[0].createdAt === bobGroup.createdAt,
+      'first ' + allGroups[0].createdAt + ' != ' + bobGroup.createdAt
+    )
+    assert(
+      allGroups[1].createdAt === camGroup.createdAt,
+      'second ' + allGroups[1].createdAt + ' != ' + camGroup.createdAt
+    )
+  }
+
+  cancelStream()
+
   return true
 })
 
@@ -296,14 +423,14 @@ test('conversation createdAt matches stream', async () => {
     allConversations.push(conversation)
   })
 
-  // Alice creates a group
+  // Alice creates a conversation
   const aliceConversation = await aliceClient.conversations.newConversation(
     bobClient.address
   )
 
   await delayToPropogate()
 
-  // Bob creates a group
+  // Bob creates a conversation
   const camConversation = await camClient.conversations.newConversation(
     aliceClient.address
   )
@@ -316,32 +443,32 @@ test('conversation createdAt matches stream', async () => {
   assert(
     allConversations[0].topic === aliceConversation.topic,
     'list()[1].topic: ' +
-    allConversations[0].topic +
-    ' != ' +
-    aliceConversation.topic
+      allConversations[0].topic +
+      ' != ' +
+      aliceConversation.topic
   )
   assert(
     allConversations[1].topic === camConversation.topic,
     'list()[0].topic: ' +
-    allConversations[1].topic +
-    ' != ' +
-    camConversation.topic
+      allConversations[1].topic +
+      ' != ' +
+      camConversation.topic
   )
 
   // CreatedAt returned from list matches createAt from create function
   assert(
     allConversations[0].createdAt === aliceConversation.createdAt,
     'list()[0].createdAt: ' +
-    allConversations[0].createdAt +
-    ' != ' +
-    aliceConversation.createdAt
+      allConversations[0].createdAt +
+      ' != ' +
+      aliceConversation.createdAt
   )
   assert(
     allConversations[1].createdAt === camConversation.createdAt,
     'list()[1].createdAt: ' +
-    allConversations[1].createdAt +
-    ' != ' +
-    camConversation.createdAt
+      allConversations[1].createdAt +
+      ' != ' +
+      camConversation.createdAt
   )
 
   return true
@@ -367,9 +494,11 @@ test('conversation createdAt matches streamAll', async () => {
 
   // Start streaming conversations
   const allConversations: ConversationContainer<any>[] = []
-  await aliceClient.conversations.streamAll(async (conversation) => {
-    allConversations.push(conversation)
-  })
+  const cancel = await aliceClient.conversations.streamAll(
+    async (conversation) => {
+      allConversations.push(conversation)
+    }
+  )
 
   // Alice creates a group
   const aliceConversation = await aliceClient.conversations.newConversation(
@@ -391,33 +520,35 @@ test('conversation createdAt matches streamAll', async () => {
   assert(
     allConversations[0].topic === aliceConversation.topic,
     'list()[1].topic: ' +
-    allConversations[0].topic +
-    ' != ' +
-    aliceConversation.topic
+      allConversations[0].topic +
+      ' != ' +
+      aliceConversation.topic
   )
   assert(
     allConversations[1].topic === camConversation.topic,
     'list()[0].topic: ' +
-    allConversations[1].topic +
-    ' != ' +
-    camConversation.topic
+      allConversations[1].topic +
+      ' != ' +
+      camConversation.topic
   )
 
   // CreatedAt returned from list matches createAt from create function
   assert(
     allConversations[0].createdAt === aliceConversation.createdAt,
     'list()[0].createdAt: ' +
-    allConversations[0].createdAt +
-    ' != ' +
-    aliceConversation.createdAt
+      allConversations[0].createdAt +
+      ' != ' +
+      aliceConversation.createdAt
   )
   assert(
     allConversations[1].createdAt === camConversation.createdAt,
     'list()[1].createdAt: ' +
-    allConversations[1].createdAt +
-    ' != ' +
-    camConversation.createdAt
+      allConversations[1].createdAt +
+      ' != ' +
+      camConversation.createdAt
   )
 
+  cancel()
+
   return true
 })
diff --git a/example/src/tests/groupTests.ts b/example/src/tests/groupTests.ts
index 79996d313..03f2d8d5e 100644
--- a/example/src/tests/groupTests.ts
+++ b/example/src/tests/groupTests.ts
@@ -455,6 +455,7 @@ test('can stream groups', async () => {
 
   // * Note Alice creating a group does not trigger alice conversations
   // group stream. Workaround is to syncGroups after you create and list manually
+  // See https://github.com/xmtp/libxmtp/issues/504
 
   // Alice creates a group
   // eslint-disable-next-line @typescript-eslint/no-unused-vars

From 5de99825069b3571a135d74c22382332077670c4 Mon Sep 17 00:00:00 2001
From: cameronvoell <cameron@xmtp.com>
Date: Tue, 20 Feb 2024 17:03:12 -0800
Subject: [PATCH 6/7] Added note about tests that fail on android

---
 example/src/tests/createdAtTests.ts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/example/src/tests/createdAtTests.ts b/example/src/tests/createdAtTests.ts
index 2f27d7635..9223e0938 100644
--- a/example/src/tests/createdAtTests.ts
+++ b/example/src/tests/createdAtTests.ts
@@ -195,6 +195,7 @@ test('group createdAt matches streamGroups', async () => {
   )
 
   // CreatedAt returned from stream matches createAt from create function
+  // Assertion below fails on Android
   if (isIos()) {
     assert(
       allGroups[0].createdAt === bobGroup.createdAt,
@@ -264,6 +265,7 @@ test('group createdAt matches streamAll', async () => {
   )
 
   // CreatedAt returned from stream matches createAt from create function
+  // Assertion below fails on Android
   if (isIos()) {
     assert(
       allGroups[0].createdAt === bobGroup.createdAt,

From 617a9209f89497782a40f4f8a687a11273c14476 Mon Sep 17 00:00:00 2001
From: cameronvoell <cameron@xmtp.com>
Date: Tue, 20 Feb 2024 17:14:26 -0800
Subject: [PATCH 7/7] share isIos function and remove console log

---
 example/src/tests/createdAtTests.ts | 10 +---------
 example/src/tests/groupTests.ts     |  2 +-
 example/src/tests/tests.ts          |  5 +++++
 3 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/example/src/tests/createdAtTests.ts b/example/src/tests/createdAtTests.ts
index 9223e0938..38a83df79 100644
--- a/example/src/tests/createdAtTests.ts
+++ b/example/src/tests/createdAtTests.ts
@@ -1,6 +1,4 @@
-import { Platform } from 'expo-modules-core'
-
-import { Test, assert, delayToPropogate } from './tests'
+import { Test, assert, delayToPropogate, isIos } from './tests'
 import {
   Client,
   Conversation,
@@ -10,10 +8,6 @@ import {
 
 export const createdAtTests: Test[] = []
 
-function isIos() {
-  return Platform.OS === 'ios'
-}
-
 function test(name: string, perform: () => Promise<boolean>) {
   createdAtTests.push({ name, run: perform })
 }
@@ -166,7 +160,6 @@ test('group createdAt matches streamGroups', async () => {
   const cancelStream = await aliceClient.conversations.streamGroups(
     async (group: Group<any>) => {
       allGroups.push(group)
-      console.log('group', allGroups.length)
     }
   )
 
@@ -236,7 +229,6 @@ test('group createdAt matches streamAll', async () => {
   const cancelStream = await aliceClient.conversations.streamAll(
     async (group: ConversationContainer<any>) => {
       allGroups.push(group)
-      console.log('group', allGroups.length)
     }
   )
 
diff --git a/example/src/tests/groupTests.ts b/example/src/tests/groupTests.ts
index 03f2d8d5e..3e77f660b 100644
--- a/example/src/tests/groupTests.ts
+++ b/example/src/tests/groupTests.ts
@@ -1,6 +1,6 @@
 import { DecodedMessage } from 'xmtp-react-native-sdk/lib/DecodedMessage'
 
-import { Test, assert, delayToPropogate } from './tests'
+import { Test, assert, delayToPropogate, isIos } from './tests'
 import {
   Client,
   Conversation,
diff --git a/example/src/tests/tests.ts b/example/src/tests/tests.ts
index 79204dca8..ce6f1b9d2 100644
--- a/example/src/tests/tests.ts
+++ b/example/src/tests/tests.ts
@@ -13,6 +13,7 @@ import {
   RemoteAttachmentCodec,
   RemoteAttachmentContent,
 } from '../../../src/index'
+import { Platform } from 'expo-modules-core'
 
 type EncodedContent = content.EncodedContent
 type ContentTypeId = content.ContentTypeId
@@ -79,6 +80,10 @@ export async function delayToPropogate(): Promise<void> {
   return new Promise((r) => setTimeout(r, 100))
 }
 
+export function isIos() {
+  return Platform.OS === 'ios'
+}
+
 function test(name: string, perform: () => Promise<boolean>) {
   tests.push({ name, run: perform })
 }