Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadBatchMessages Fails for Invalid Signature only on Android #196

Closed
nplasterer opened this issue Jan 2, 2024 · 0 comments · Fixed by #199
Closed

loadBatchMessages Fails for Invalid Signature only on Android #196

nplasterer opened this issue Jan 2, 2024 · 0 comments · Fixed by #199
Assignees
Labels
bug Something isn't working

Comments

@nplasterer
Copy link
Contributor

On a specific topic, I get Error: Call to function 'XMTP.loadBatchMessages' has been rejected. → Caused by: org.xmtp.android.library.XMTPException: Invalid signature
Checking out the Kotlin code, it fails here: https://github.com/xmtp/xmtp-android/blob/main/library/src/main/java/org/xmtp/android/library/messages/MessageV2.kt#L98
Two things
this syncs well on iOS, any idea how this would not fail on iOS but fail on Android? Equivalent Swift code: https://github.com/xmtp/xmtp-ios/blob/main/Sources/XMTP/Messages/MessageV2.swift#L47-L49
do you think the whole loadBatchMessages should fail in that case? Or should it just return the messages that work well (and notify there were some issues)
MessageV2.kt
https://github.com/[xmtp/xmtp-android](https://github.com/xmtp/xmtp-android)|xmtp/xmtp-androidxmtp/xmtp-android | Added by https://xmtp-labs.slack.com/services/B05RXSHK0SX
MessageV2.swift
https://github.com/[xmtp/xmtp-ios](https://github.com/xmtp/xmtp-ios)|xmtp/xmtp-iosxmtp/xmtp-ios | Added by https://xmtp-labs.slack.com/services/B05RXSHK0SX

@nplasterer nplasterer added the bug Something isn't working label Jan 2, 2024
@alexrisch alexrisch assigned alexrisch and unassigned alexrisch Jan 3, 2024
@nplasterer nplasterer self-assigned this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants