Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Remove Ethers as a dependency #186

Closed
peterferguson opened this issue Dec 17, 2023 · 2 comments · Fixed by #215
Closed

Feature request: Remove Ethers as a dependency #186

peterferguson opened this issue Dec 17, 2023 · 2 comments · Fixed by #215
Assignees
Labels
enhancement New feature or request

Comments

@peterferguson
Copy link
Contributor

peterferguson commented Dec 17, 2023

Is your feature request related to a problem?

Hey glad to see this package getting so much love over the past few weeks!

Since there are more people working on the package now I was wondering whether there would be capacity to remove ethers as a dependency. This is currently to the last library we have that depends explicitly on it & we would really like to remove it from our bundle.

It is really only used here & what it is being used for could easily be broken out into a util in this code base. Or it could even be pushed to the user (probably not ideal).

The benefit here would be allowing the user to decide which type of Signer (viem, ethers, ...) they pass to the Client as long as it has a signMessage method.

Describe the solution to the problem

No response

Describe the uses cases for the feature

No response

Additional details

No response

@peterferguson peterferguson added the enhancement New feature or request label Dec 17, 2023
@nplasterer
Copy link
Contributor

@peterferguson thanks for reporting! This is something we all really want as well.

I went through our code to flag the items that we currently use it for
util.splitSignature
signer.signMessage
signer.getAddress

Looks like its really only on creating a client so we should be able to try and prioritize the removal of this. 🙏

@cameronvoell
Copy link
Contributor

thanks for taking care of this @kele-leanes !

@peterferguson let us know if you have any issues using viem or other non ethers signer 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants