feat: consent proofs #599
Merged
feat: consent proofs #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Protos Added ability to add consent proofs to conversations Updated types Added consentProof on Invitiation class
alexrisch
force-pushed
the
ar/consent-proofs
branch
from
0b777bc to
d71b473
Compare
Deploying xmtp-js-docs with
|
| Latest commit: |
a4959af
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://79126777.xmtp-js.pages.dev |
| Branch Preview URL: | https://ar-consent-proofs.xmtp-js.pages.dev |
Verified consent proofs Added tests for consent proofs
Verified consent proofs Added tests for consent proofs
alexrisch
commented
Apr 24, 2024
Verified consent proofs Added tests for consent proofs
neekolas
reviewed
Apr 24, 2024
neekolas
reviewed
Apr 24, 2024
neekolas
reviewed
Apr 24, 2024
added 2 commits
April 30, 2024 16:13
Updated consent proof handling to be on the updateV2Conversations method instead
Updated consent list to handle consent proofs
neekolas
reviewed
May 1, 2024
src/Contacts.ts
Outdated
| conversations.forEach((conversation) => { | ||
| if ( | ||
| conversation.consentProof && | ||
| this.consentState(conversation.peerAddress) === 'unknown' |
There was a problem hiding this comment.
This looks good. It'll always have the current value from the network because this.consentList.load(...) mutates this.consentList as it goes, right?
neekolas
reviewed
May 1, 2024
neekolas
approved these changes
May 1, 2024
rygine
reviewed
May 1, 2024
rygine
reviewed
May 1, 2024
Updated to validate and approve as array Added timestamp validation
rygine
reviewed
May 1, 2024
rygine
reviewed
May 1, 2024
rygine
reviewed
May 1, 2024
Validate signatures synchronously Moved to reduce Removed handle Consent proof method
rygine
approved these changes
May 1, 2024
|
🎉 This PR is included in version 11.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Protos
Added ability to add consent proofs to conversations Updated types
Added consentProof on Invitiation class