Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Conversations with invalid topics should not be included in the conversation list #491

Closed
nakajima opened this issue Nov 13, 2023 · 2 comments · Fixed by #495
Closed

Bug: Conversations with invalid topics should not be included in the conversation list #491

nakajima opened this issue Nov 13, 2023 · 2 comments · Fixed by #495
Labels
bug Something isn't working released on @beta released

Comments

@nakajima
Copy link
Contributor

Describe the bug

There was a version of the JS SDK that generated invalid non-ascii topics that could cause issues in some clients. If those are found in the conversation list we should filter them out.

Expected behavior

No response

Steps to reproduce the bug

No response
@nakajima nakajima added the bug Something isn't working label Nov 13, 2023
@rygine rygine mentioned this issue Nov 28, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

🎉 This issue has been resolved in version 11.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

🎉 This issue has been resolved in version 11.3.0-beta.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

filter out conversations with invalid topics xmtp/xmtp-js
1 participant
@nakajima