From 09a4af85a0190190399c6537d6ccddc0cac539f3 Mon Sep 17 00:00:00 2001 From: Ry Racherbaumer Date: Wed, 4 Dec 2024 12:42:30 -0600 Subject: [PATCH] Set shouldPush to false to reactions --- .../src/Reaction.test.ts | 20 ++----------------- .../content-type-reaction/src/Reaction.ts | 4 ++-- 2 files changed, 4 insertions(+), 20 deletions(-) diff --git a/content-types/content-type-reaction/src/Reaction.test.ts b/content-types/content-type-reaction/src/Reaction.test.ts index ada9c5d26..b9a0d9da1 100644 --- a/content-types/content-type-reaction/src/Reaction.test.ts +++ b/content-types/content-type-reaction/src/Reaction.test.ts @@ -97,24 +97,8 @@ describe("ReactionContentType", () => { expect(messageContent.schema).toBe("shortcode"); }); - it("has a proper shouldPush value based on content", () => { + it("has a proper shouldPush value", () => { const codec = new ReactionCodec(); - - const addReaction: Reaction = { - action: "added", - content: "smile", - reference: "foo", - schema: "shortcode", - }; - - const removeReaction: Reaction = { - action: "removed", - content: "smile", - reference: "foo", - schema: "shortcode", - }; - - expect(codec.shouldPush(addReaction)).toBe(true); - expect(codec.shouldPush(removeReaction)).toBe(false); + expect(codec.shouldPush()).toBe(false); }); }); diff --git a/content-types/content-type-reaction/src/Reaction.ts b/content-types/content-type-reaction/src/Reaction.ts index 021539be4..9c442a28b 100644 --- a/content-types/content-type-reaction/src/Reaction.ts +++ b/content-types/content-type-reaction/src/Reaction.ts @@ -101,7 +101,7 @@ export class ReactionCodec } } - shouldPush(content: Reaction): boolean { - return content.action === "added"; + shouldPush(): boolean { + return false; } }