Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Conversations with invalid topics should not be included in the conversation list #186

Closed
nakajima opened this issue Nov 13, 2023 · 0 comments · Fixed by #194
Closed

Bug: Conversations with invalid topics should not be included in the conversation list #186

nakajima opened this issue Nov 13, 2023 · 0 comments · Fixed by #194
Labels
bug Something isn't working

Comments

@nakajima
Copy link
Contributor

Describe the bug

There was a version of the JS SDK that generated invalid non-ascii topics that could cause issues in some clients. If those are found in the conversation list we should filter them out.

Expected behavior

No response

Steps to reproduce the bug

No response
@nakajima nakajima added the bug Something isn't working label Nov 13, 2023
@giovasdistillery giovasdistillery linked a pull request Nov 25, 2023 that will close this issue
Removing conversations that contain a no valid topic #194
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing conversations that contain a no valid topic xmtp/xmtp-ios
1 participant
@nakajima