Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to get the original bytes of the wrp #37

Closed
kristinapathak opened this issue Oct 30, 2019 · 3 comments
Closed

Add a way to get the original bytes of the wrp #37

kristinapathak opened this issue Oct 30, 2019 · 3 comments
Assignees
@kristinapathak
Labels
enhancement New feature or request

Comments

@kristinapathak
Copy link
Contributor

Consumers don't want to spend resources re-encoding a wrp into the same form they received it in (ex: MsgPack -> wrp struct -> MsgPack). We want them to be able to easily use the original encoding if no fields have changed. Otherwise, they have to re-encode.
@kristinapathak kristinapathak added the enhancement New feature or request label Oct 30, 2019
@kristinapathak kristinapathak self-assigned this Oct 30, 2019
@kristinapathak
Copy link
Contributor Author

Related to xmidt-org/caduceus#174

@kristinapathak
Copy link
Contributor Author

@johnabass pointed out that this might be similar or what we want:
https://github.com/xmidt-org/wrp-go/blob/master/wrphttp/requestResponse.go#L30

@kristinapathak kristinapathak mentioned this issue Nov 6, 2019
Open
@joe94 joe94 mentioned this issue Feb 11, 2020
Merged
@joe94
Copy link
Member

joe94 commented Feb 11, 2020

Fixed by #43

@joe94 joe94 closed this as completed Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kristinapathak kristinapathak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joe94 @kristinapathak