tests for jwt expiration #189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
==========================================
+ Coverage 88.27% 88.42% +0.15%
==========================================
Files 41 41
Lines 4426 4518 +92
Branches 358 361 +3
==========================================
+ Hits 3907 3995 +88
- Misses 188 189 +1
- Partials 331 334 +3
Continue to review full report at Codecov.
|
schmidtw
reviewed
Apr 20, 2018
src/connection.c
Outdated
| @@ -35,6 +35,8 @@ | |||
|
|
|||
| #define HTTP_CUSTOM_HEADER_COUNT 5 | |||
| #define INITIAL_CJWT_RETRY -2 | |||
| #define Parodus_Print printf | |||
schmidtw
reviewed
Apr 20, 2018
src/connection.c
Outdated
| @@ -192,12 +194,12 @@ int createNopollConnection(noPollCtx *ctx) | |||
| } | |||
| if(allow_insecure <= 0) | |||
| { | |||
| ParodusPrint("secure true\n"); | |||
| Parodus_Print("secure true\n"); | |||
There was a problem hiding this comment.
This change should be reverted.
schmidtw
reviewed
Apr 20, 2018
src/connection.c
Outdated
| connection = nopoll_tls_common_conn(ctx,server_Address, port, extra_headers,&fallback); | ||
| } | ||
| else | ||
| { | ||
| ParodusPrint("secure false\n"); | ||
| Parodus_Print("secure false\n"); |
There was a problem hiding this comment.
This change should be reverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle jwt expiration
and tests.