Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): remove not supported plugin 'kotlin-android-extensions' #115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JeffGuKang
Copy link

@JeffGuKang JeffGuKang commented Aug 4, 2023

  • React Native: 0.72.3

Correct error below.

The Android extensions ('kotlin-android-extensions') compiler plugin is no longer supported. Please use kotlin parcelize and view binding. More information: https://goo.gle/kotlin-android-extensions-deprecation FAILURE: Build failed with an exception. * What went wrong:
Execution failed for task ':xmartlabs_react-native-line:compileDebugKotlin'.

My android/build.gradle

// https://rnfirebase.io/#android
project.ext {
  set('react-native', [
    versions: [
      // Overriding Build/Android SDK Versions
      android : [
        minSdk    : 19,
        targetSdk : 33,
        compileSdk: 33,
      ],

      // Overriding Library SDK Versions
      firebase: [
        // Override Firebase SDK Version
        bom           : "32.1.0"
      ],
    ],
  ])
}

buildscript {
    ext {
        buildToolsVersion = "33.0.0"
        minSdkVersion = 21
        compileSdkVersion = 33
        targetSdkVersion = 31
       
        ndkVersion = "23.1.7779620"
        kotlinVersion = '1.8.0'
    }

....

PR Title

fix(android): remove not supported plugin 'kotlin-android-extensions'

🔄 Type of change:

  • ✨Feature/chore
  • ♻️ Refactor
  • 🔧 Bugfixes

✏️ Description:

Add a description of the feature or bug you are tackling. First in high level perspective and then you can describe your solution. Include acceptance criteria, diagrams of the code, or anything else you consider that might help other developers understand your decisions.


🎥 Screen record:

Add a screen record of the execution of your functionality. This way the reviewer can better understand what has been added.


📌 Notes:

  • Include pending tasks, TODOs, assumptions, or comments like 'Needs migrating', or 'Requires ENV vars: [..]'

✔️Tasks:

  • Include a medium-level tasking that summarizes the changes in the code

⚠️ Warnings:

  • Include a list of considerations for reviewers or future developers. For example:
  • The feature in production triggers a service call so it will charge the account credit card
  • The service X is mocked so this part is not tested

….gradle

kotlin-android-extensions

```
The Android extensions ('kotlin-android-extensions') compiler plugin is no longer supported. Please use kotlin parcelize and view binding. More information: https://goo.gle/kotlin-android-extensions-deprecation FAILURE: Build failed with an exception. * What went wrong:
Execution failed for task ':xmartlabs_react-native-line:compileDebugKotlin'.
```
Copy link

@zee0786 zee0786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me

@wacci6
Copy link

wacci6 commented Jul 4, 2024

@emibotti @nicoache1 @santiagofm @mcousillas6 @blackbing @nonth @MarcoF09 @toshi3221 @ht-jo @jeong-sik @manikandanb24

Can someone with write access please handle this?

@wacci6
Copy link

wacci6 commented Aug 19, 2024

@xmartlabs
Could you handle this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants