feat: New curp conflict pool #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsbds
force-pushed
the
curp-conflict-pool-new
branch
2 times, most recently
from
bca6be2 to
51753e3
Compare
bsbds
force-pushed
the
curp-conflict-pool-new
branch
from
7065fbd to
2fea605
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #675 +/- ##
==========================================
+ Coverage 75.45% 75.62% +0.17%
==========================================
Files 176 180 +4
Lines 26515 26938 +423
Branches 26515 26938 +423
==========================================
+ Hits 20006 20371 +365
- Misses 5297 5346 +49
- Partials 1212 1221 +9 ☔ View full report in Codecov by Sentry. |
Phoenix500526
previously approved these changes
Mar 27, 2024
Signed-off-by: bsbds <[email protected]>
bsbds
force-pushed
the
curp-conflict-pool-new
branch
from
a13ebad to
c028750
Compare
rogercloud
reviewed
Apr 3, 2024
Signed-off-by: bsbds <[email protected]>
rogercloud
approved these changes
Apr 3, 2024
Phoenix500526
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
First PR of refactor: enable new sp/ucp implementation #668.
Implements new speculative pool and uncommitted pool in curp.
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)