feat: replace hardcoded temp directory paths #974
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I replaced all the hardcoded paths under |
|
Hi, please update the PR to resolve CI issues. |
Signed-off-by: Pengyu Wang <[email protected]>
bsbds
reviewed
Sep 3, 2024
| @@ -35,3 +35,4 @@ workspace-hack = { version = "0.1", path = "../../workspace-hack" } | |||
|
|
|||
| [dev-dependencies] | |||
| test-macros = { path = "../test-macros" } | |||
| tempfile = "3" | |||
There was a problem hiding this comment.
Please add a new line at the end.
| @@ -756,7 +757,7 @@ mod test { | |||
| }; | |||
| let res = engine.apply_snapshot(fake_snapshot, &["not_exist"]).await; | |||
| assert!(res.is_err()); | |||
| fs::remove_dir_all(dir).unwrap(); | |||
| dir.close().unwrap(); | |||
| } | |||
|
|
|||
| #[test] | |||
There was a problem hiding this comment.
The test_engine_size test also needs to be updated for consistency.
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 14 days |
|
This PR was closed because it has been stalled for 14 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
Fixes [feature]: replace hardcoding "/tmp/xxx" path #933
This PR replaces the hardcoded tmp path with calls to tempfile crate