Merge branch refactor-v0.7.0-new
#962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]> chore: add reminder of a revision issue Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
refactor: remove cmd worker and mpmc channel from task manager Signed-off-by: bsbds <[email protected]> refactor: cmd trait Signed-off-by: bsbds <[email protected]> WIP: fix rebase cmd worker refactor: change command execute from async to sync Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
refactor: curp server refactor: update auth wrapper with the new stream api refactor: log persistent refactor: add new tasks to task manager WIP: command execution chore: clippy task manager chore: clippy client tests mock client chore: client retry chore: clippy curp error pattern match chore: clippy client tests Signed-off-by: bsbds <[email protected]> refactor: implement ResponseSender and ResponseReceiver chore: clippy response receiver Signed-off-by: bsbds <[email protected]> chore: remove log persistent task from task manager Signed-off-by: bsbds <[email protected]> fix: return immediately when receiving an error on propose Signed-off-by: bsbds <[email protected]> refactor: command execution logic Signed-off-by: bsbds <[email protected]> chore: fix clippy Signed-off-by: bsbds <[email protected]> fix: use propose id for read only cmds Signed-off-by: bsbds <[email protected]>
Request::set_timeout only works on the server side, if the server is not ready, the client may wait indefinitely Signed-off-by: bsbds <[email protected]>
…tonic doesn't support it Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]> fix: test ce Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
This check is not necessary, the urls are allowed to be empty before publish Signed-off-by: bsbds <[email protected]>
Because client id may change during retry, the propose id generation must be called for each retry Signed-off-by: bsbds <[email protected]>
It seems sync wait on a event listener will potentialy cause a deadlock, we will address this in the future. Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
bsbds
force-pushed
the
merge-refactor-v0.7
branch
from
60bd0d4 to
97f6232
Compare
Signed-off-by: bsbds <[email protected]>
bsbds
force-pushed
the
merge-refactor-v0.7
branch
from
97f6232 to
1157cbd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #962 +/- ##
==========================================
- Coverage 75.55% 75.19% -0.37%
==========================================
Files 180 189 +9
Lines 26938 28376 +1438
Branches 26938 28376 +1438
==========================================
+ Hits 20353 21337 +984
- Misses 5366 5750 +384
- Partials 1219 1289 +70 ☔ View full report in Codecov by Sentry. |
Signed-off-by: bsbds <[email protected]>
|
@bsbds Convert your pr to draft since CI failed |
bsbds
force-pushed
the
merge-refactor-v0.7
branch
from
74467e2 to
0079e9c
Compare
Signed-off-by: bsbds <[email protected]>
bsbds
force-pushed
the
merge-refactor-v0.7
branch
from
0079e9c to
6fa7400
Compare
Signed-off-by: bsbds <[email protected]>
bsbds
force-pushed
the
merge-refactor-v0.7
branch
from
6fa7400 to
5843ee5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge branch
refactor-v0.7.0-newinto master.Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)