-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature]: replace hardcoding "/tmp/xxx" path #933
Comments
👋 Thanks for opening this issue! Reply with the following command on its own line to get help or engage:
|
Hello there, I am new to the project and would love to contribute! I’d love to take a stab at this one. |
feel free to comment |
/assignme |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
Have been occupied by other stuff, will work on this later. |
Hi @lxl66566, I'm interested in contributing to this issue. Let me give it a try and work on solving it. |
@JianMinTang Thank you for your enthusiasm! |
currently we use many
/tmp/xxx
temp directory on db testing, and needs manually delete the dir in the end of test.It's better to use some crate like tempfile to help us.
pros:
things to do:
[dev-dependencies]
and replace/tmp/xxx
path/tmp/xxx
path not in test mod, ex. crates/xline/src/server/command.rs, use std::env::temp_dir instead.The text was updated successfully, but these errors were encountered: