-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(xlineapi): improve is_conflict #932
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #932 +/- ##
==========================================
- Coverage 75.55% 75.12% -0.43%
==========================================
Files 180 191 +11
Lines 26938 28539 +1601
Branches 26938 28539 +1601
==========================================
+ Hits 20353 21441 +1088
- Misses 5366 5801 +435
- Partials 1219 1297 +78 ☔ View full report in Codecov by Sentry. |
@lxl66566 Your PR is in conflict and cannot be merged. |
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 14 days |
13a44c6
to
2fe4785
Compare
2fe4785
to
a6e0129
Compare
@lxl66566 Convert your pr to draft since CI failed |
Signed-off-by: lxl66566 <[email protected]> refactor(xlineapi): complete refactor Signed-off-by: lxl66566 <[email protected]>
Signed-off-by: lxl66566 <[email protected]>
Signed-off-by: lxl66566 <[email protected]>
a6e0129
to
a6d3449
Compare
@lxl66566 Convert your pr to draft since CI failed |
Signed-off-by: lxl66566 <[email protected]>
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
is_conflict
method #379what changes does this pull request make?
lease()
. The PR is mainly to solve the first type of check rules.are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)