Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EtcdAPI][Feature]: Support set version? #867

Closed
1 task done
liangyuanpeng opened this issue Jun 25, 2024 · 7 comments
Closed
1 task done

[EtcdAPI][Feature]: Support set version? #867

liangyuanpeng opened this issue Jun 25, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request Stale

Comments

@liangyuanpeng
Copy link
Contributor

liangyuanpeng commented Jun 25, 2024

Description about the feature

kubernetes 1.31(master) will begin to require a certain version of etcd to use some feature, and xline has its own version number, which means that if the xline's Maintenance.Status request returns a version number that does not correspond to etcd, it will never run in this case.

https://github.com/kubernetes/kubernetes/blob/8cf93c8d83df3a206ab4abe2ed2ead7a173bd63e/staging/src/k8s.io/apiserver/pkg/storage/feature/feature_support_checker.go#L157-L172

cilium also have the same problem.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@liangyuanpeng liangyuanpeng added the enhancement New feature or request label Jun 25, 2024
Copy link

👋 Thanks for opening this issue!

Reply with the following command on its own line to get help or engage:

  • /contributing-agreement : to print Contributing Agreements.
  • /assignme : to assign this issue to you.

@CrystalAnalyst CrystalAnalyst self-assigned this Jun 28, 2024
@CrystalAnalyst
Copy link
Contributor

Thanks for the considerate suggesion!
Since our project already supports the RequestWatchProgress function, indicating that Xline already has the necessary compatibility for systems such as Kubernetes that rely on this function.
This means that if Xline is used as an etcd replacement, it can meet the requirements for Kubernetes ,
compatible with etcd 3.5.13(and above) without the need for specific compatibility.

@liangyuanpeng
Copy link
Contributor Author

liangyuanpeng commented Jul 29, 2024

Hi @CrystalAnalyst , sorry for not clear it, kubernetes/ cilium will check the version with grpc api Maintenance.Status.

for example:

  1. kubernetes/cilium get the version 3.5 with grpc api Maintenance.Status
  2. if version <3.5, exit the program or prompt that the feature is not supported.
    2.1) etcd return 3.5.15, success running
    2.2) xline return 0.6.1, failed running

So this issue is requesting for xline can return the special version from grpc api and not the really xline version (0.6.1), RequestWatchProgress is not the point.

Remind me if i have not clear it.

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 29, 2024
@liangyuanpeng
Copy link
Contributor Author

no stale

@github-actions github-actions bot removed the Stale label Aug 30, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 29, 2024
Copy link

This issue was closed because it has been stalled for 14 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
None yet
Development

No branches or pull requests

2 participants