refactor: remove sleep_secs method when waiting the cluster to shutdown #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Phoenix500526 Convert your pr to draft since CI failed |
Phoenix500526
force-pushed
the
shutdown_timeout
branch
from
9091f52 to
014a9cc
Compare
|
@Phoenix500526 You've modified the workflows. Please don't forget to update the .mergify.yml. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #786 +/- ##
==========================================
- Coverage 75.55% 75.49% -0.06%
==========================================
Files 180 186 +6
Lines 26938 27472 +534
Branches 26938 27472 +534
==========================================
+ Hits 20353 20741 +388
- Misses 5366 5460 +94
- Partials 1219 1271 +52 ☔ View full report in Codecov by Sentry. |
|
@Phoenix500526 Your PR is in conflict and cannot be merged. |
Signed-off-by: Phoeniix Zhao <[email protected]>
Phoenix500526
force-pushed
the
shutdown_timeout
branch
2 times, most recently
from
cb26085 to
7026b00
Compare
rogercloud
reviewed
May 5, 2024
Phoenix500526
force-pushed
the
shutdown_timeout
branch
2 times, most recently
from
bc2a242 to
afa5f43
Compare
rogercloud
previously approved these changes
May 12, 2024
Signed-off-by: Phoeniix Zhao <[email protected]>
Phoenix500526
force-pushed
the
shutdown_timeout
branch
from
afa5f43 to
c377994
Compare
rogercloud
approved these changes
May 20, 2024
bsbds
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
Using a notify logic to instead the sleep logic in some integration test cases
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)