feat: implement rocks transaction #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsbds
force-pushed
the
impl-rocks-transaction
branch
2 times, most recently
from
4d132fe to
34e5e62
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #703 +/- ##
==========================================
- Coverage 75.55% 75.39% -0.16%
==========================================
Files 180 187 +7
Lines 26938 27960 +1022
Branches 26938 27960 +1022
==========================================
+ Hits 20353 21081 +728
- Misses 5366 5590 +224
- Partials 1219 1289 +70 ☔ View full report in Codecov by Sentry. |
|
@bsbds Your PR is in conflict and cannot be merged. |
bsbds
force-pushed
the
impl-rocks-transaction
branch
from
34e5e62 to
61de1a9
Compare
|
@bsbds Convert your pr to draft since CI failed |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
Phoenix500526
force-pushed
the
impl-rocks-transaction
branch
from
61de1a9 to
5fc6fee
Compare
|
@bsbds Convert your pr to draft since CI failed |
bsbds
force-pushed
the
impl-rocks-transaction
branch
from
5fc6fee to
51ecfc0
Compare
|
@bsbds Convert your pr to draft since CI failed |
bsbds
force-pushed
the
impl-rocks-transaction
branch
from
46050fe to
44a5319
Compare
bsbds
force-pushed
the
impl-rocks-transaction
branch
2 times, most recently
from
0aba376 to
7e010f6
Compare
|
@bsbds Convert your pr to draft since CI failed |
bsbds
force-pushed
the
impl-rocks-transaction
branch
from
7e010f6 to
9ab8374
Compare
bsbds
force-pushed
the
impl-rocks-transaction
branch
from
9ab8374 to
a2e29bd
Compare
Phoenix500526
previously approved these changes
May 16, 2024
rogercloud
reviewed
May 20, 2024
|
@bsbds Convert your pr to draft since CI failed |
bsbds
force-pushed
the
impl-rocks-transaction
branch
from
b58dea1 to
fe33188
Compare
|
Please squash the commits |
Signed-off-by: bsbds <[email protected]>
bsbds
force-pushed
the
impl-rocks-transaction
branch
from
fe33188 to
80e3aeb
Compare
Phoenix500526
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: #674
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Implement txn API for rocksdb engine.
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)