feat: implement memory transaction #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #702 +/- ##
==========================================
- Coverage 75.55% 75.32% -0.24%
==========================================
Files 180 187 +7
Lines 26938 27665 +727
Branches 26938 27665 +727
==========================================
+ Hits 20353 20838 +485
- Misses 5366 5542 +176
- Partials 1219 1285 +66 ☔ View full report in Codecov by Sentry. |
|
@bsbds Your PR is in conflict and cannot be merged. |
bsbds
force-pushed
the
impl-memory-transaction
branch
from
7feeffa to
8ccf23b
Compare
|
@bsbds Convert your pr to draft since CI failed |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
Phoenix500526
force-pushed
the
impl-memory-transaction
branch
from
8ccf23b to
d7813f9
Compare
bsbds
force-pushed
the
impl-memory-transaction
branch
from
d7813f9 to
df8a6da
Compare
Signed-off-by: bsbds <[email protected]>
bsbds
force-pushed
the
impl-memory-transaction
branch
from
df8a6da to
fe77c41
Compare
rogercloud
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: #674
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Implement txn API for memory engine.
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)