feat: support redirecting the logs to the terminal #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #686 +/- ##
==========================================
+ Coverage 75.55% 75.76% +0.20%
==========================================
Files 180 187 +7
Lines 26938 27824 +886
Branches 26938 27824 +886
==========================================
+ Hits 20353 21080 +727
- Misses 5366 5451 +85
- Partials 1219 1293 +74 ☔ View full report in Codecov by Sentry. |
GFX9
force-pushed
the
dev
branch
4 times, most recently
from
7cb4b17 to
1a4e49c
Compare
GFX9
force-pushed
the
dev
branch
2 times, most recently
from
8ed8c85 to
ba0a6bb
Compare
GFX9
force-pushed
the
dev
branch
2 times, most recently
from
ddbd088 to
9a592d1
Compare
GFX9
force-pushed
the
dev
branch
2 times, most recently
from
e4c7cd7 to
4aa940d
Compare
bsbds
reviewed
Apr 15, 2024
|
@GFX9 Convert your pr to draft since CI failed |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
|
@GFX9 Convert your pr to draft since CI failed |
Phoenix500526
force-pushed
the
dev
branch
4 times, most recently
from
9da6fcf to
1909c14
Compare
|
@GFX9 Convert your pr to draft since CI failed |
rogercloud
reviewed
Jun 7, 2024
|
@GFX9 Convert your pr to draft since CI failed |
|
@GFX9 Your PR is in conflict and cannot be merged. |
Signed-off-by: GFX9 <[email protected]>
rogercloud
approved these changes
Jun 13, 2024
bsbds
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
-> Fixes [Feature]: Add an command line option to enable stdout log ouput #670
-> Currently, Xline does not support redirecting the logs to the terminal. It outputs to a specified log file through
--log-filein command line. If the user does not specify this parameter, the file path/var/log/xlineis created by default.what changes does this pull request make?
-> Checks whether the user specifies
--log-file. If not, output the logs to the terminal and ignore--log-rotateif provided.are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
-> No