Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics doc #685

Merged
merged 6 commits into from
May 20, 2024
Merged

Metrics doc #685

merged 6 commits into from
May 20, 2024

Conversation

iGxnon
Copy link
Contributor

@iGxnon iGxnon commented Mar 9, 2024

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
  • Change quick start
  • Fix benchmark
  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 56.41026% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 75.49%. Comparing base (e35b35a) to head (239b85c).
Report is 84 commits behind head on master.

Files Patch % Lines
crates/curp/src/server/metrics.rs 62.50% 12 Missing ⚠️
crates/curp/src/server/raw_curp/mod.rs 0.00% 3 Missing ⚠️
crates/curp/src/server/curp_node.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #685      +/-   ##
==========================================
- Coverage   75.55%   75.49%   -0.06%     
==========================================
  Files         180      186       +6     
  Lines       26938    27478     +540     
  Branches    26938    27478     +540     
==========================================
+ Hits        20353    20745     +392     
- Misses       5366     5458      +92     
- Partials     1219     1275      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Phoenix500526
Phoenix500526 previously approved these changes Mar 18, 2024
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iGxnon
Copy link
Contributor Author

iGxnon commented Mar 19, 2024

/cc @bsbds
Could you take a look?

doc/metrics.md Outdated Show resolved Hide resolved
doc/quick-start/Dockerfile Show resolved Hide resolved
scripts/prometheus.yml Show resolved Hide resolved
rogercloud
rogercloud previously approved these changes Apr 8, 2024
Copy link

mergify bot commented Apr 18, 2024

@iGxnon Convert your pr to draft since CI failed

@mergify mergify bot marked this pull request as draft April 18, 2024 06:52
@mergify mergify bot requested a review from a team April 19, 2024 04:36
@Phoenix500526
Copy link
Collaborator

@Mergifyio rebase

Copy link

mergify bot commented Apr 25, 2024

rebase

✅ Branch has been successfully rebased

@Phoenix500526 Phoenix500526 marked this pull request as ready for review April 25, 2024 15:11
Copy link

mergify bot commented Apr 29, 2024

@iGxnon Convert your pr to draft since CI failed

@mergify mergify bot marked this pull request as draft April 29, 2024 06:17
@iGxnon iGxnon marked this pull request as ready for review May 4, 2024 03:52
@iGxnon
Copy link
Contributor Author

iGxnon commented May 4, 2024

rebased manually

Phoenix500526
Phoenix500526 previously approved these changes May 9, 2024
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot requested a review from a team May 9, 2024 08:19
rogercloud
rogercloud previously approved these changes May 12, 2024
@mergify mergify bot requested a review from a team May 12, 2024 13:58
Copy link

mergify bot commented May 12, 2024

@iGxnon Your PR is in conflict and cannot be merged.

@Phoenix500526 Phoenix500526 dismissed stale reviews from rogercloud and themself via 239b85c May 17, 2024 06:03
@mergify mergify bot requested a review from a team May 17, 2024 09:36
@Phoenix500526 Phoenix500526 merged commit 9cc7cfb into xline-kv:master May 20, 2024
13 of 14 checks passed
@mergify mergify bot requested a review from a team May 20, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants