-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics doc #685
Metrics doc #685
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #685 +/- ##
==========================================
- Coverage 75.55% 75.49% -0.06%
==========================================
Files 180 186 +6
Lines 26938 27478 +540
Branches 26938 27478 +540
==========================================
+ Hits 20353 20745 +392
- Misses 5366 5458 +92
- Partials 1219 1275 +56 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cc @bsbds |
@iGxnon Convert your pr to draft since CI failed |
@Mergifyio rebase |
✅ Branch has been successfully rebased |
4459545
to
6aeafa5
Compare
@iGxnon Convert your pr to draft since CI failed |
rebased manually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@iGxnon Your PR is in conflict and cannot be merged. |
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
39e1bff
to
239b85c
Compare
Please briefly answer these questions:
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)