Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant stuff #1016

Merged
merged 1 commit into from
Nov 15, 2024
Merged

chore: remove redundant stuff #1016

merged 1 commit into from
Nov 15, 2024

Conversation

iGxnon
Copy link
Contributor

@iGxnon iGxnon commented Oct 30, 2024

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

Copy link

mergify bot commented Oct 30, 2024

@iGxnon You've modified the workflows. Please don't forget to update the .mergify.yml.

@mergify mergify bot requested a review from a team October 30, 2024 09:27
USAGE.md Show resolved Hide resolved
Copy link

mergify bot commented Oct 30, 2024

@iGxnon Convert your pr to draft since CI failed

@mergify mergify bot marked this pull request as draft October 30, 2024 09:35
@mergify mergify bot added the CI:fail CI has failed label Oct 30, 2024
@iGxnon iGxnon marked this pull request as ready for review October 31, 2024 00:48
@iGxnon iGxnon mentioned this pull request Nov 8, 2024
1 task
@iGxnon iGxnon requested a review from bsbds November 14, 2024 16:16
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.17%. Comparing base (e35b35a) to head (5d1b76e).
Report is 330 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1016      +/-   ##
==========================================
- Coverage   75.55%   75.17%   -0.38%     
==========================================
  Files         180      190      +10     
  Lines       26938    28480    +1542     
  Branches    26938    28480    +1542     
==========================================
+ Hits        20353    21411    +1058     
- Misses       5366     5771     +405     
- Partials     1219     1298      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bsbds bsbds merged commit 50cd2c5 into xline-kv:master Nov 15, 2024
15 checks passed
@mergify mergify bot requested a review from a team November 15, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI:fail CI has failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants