Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eureka/Bozja data when a character has no Bozja #17

Closed
nazdir opened this issue Nov 24, 2021 · 4 comments
Closed

Eureka/Bozja data when a character has no Bozja #17

nazdir opened this issue Nov 24, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@nazdir
Copy link
Contributor

nazdir commented Nov 24, 2021

Describe the bug
When a character has never done Bozja content but has done Eureka, Bozja data is parsed as if it is Eureka data.

To Reproduce
Steps to reproduce the behavior:
parse character id 3981995 (Amet Sy @ Famfrit)

Expected behavior
A ClassJobBozjan object with 0s and a ClassJobElemental object with Eureka data.

Additional context
Objects returned appear as such
ClassJobBozjan: { Level: 2, Mettle: 642, Name: "Elemental Level" }
ClassJobElemental: { ExpLevel: 0, ExpLevelMax: 0, ExpLevelTogo: 0, Level: 0, Name: "" },

@nazdir nazdir added the bug Something isn't working label Nov 24, 2021
@karashiiro
Copy link
Member

This is probably more of a selectors bug, but it doesn't have a solution: xivapi/lodestone-css-selectors#12

@karashiiro
Copy link
Member

I should be able to add special handling for this.

karashiiro added a commit that referenced this issue Nov 25, 2021
@karashiiro
Copy link
Member

Released v2.1.5, let me know if that fixes it.

@nazdir
Copy link
Contributor Author

nazdir commented Nov 25, 2021

I originally mentioned it as a selectors bug in xivapi Discord but I had no idea how it could be fixed.
This seems to have handled it perfectly. I really appreciate it. Hopefully whatever the new Eureka/Bozja is will get better selectors on the Lodestone.

@nazdir nazdir closed this as completed Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants