Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Cached results persist when updating Sim Settings #389

Open
Chromatophore opened this issue Oct 27, 2024 · 0 comments
Open

Bug: Cached results persist when updating Sim Settings #389

Chromatophore opened this issue Oct 27, 2024 · 0 comments

Comments

@Chromatophore
Copy link
Contributor

If you modify a sim's settings, it appears the cached results of the sim will persist, with no clear method to re run it. Since all sims have Party Buff options, all sims are probably impacted.

The 2 actions I've found that will re run sims are
a) Changing gear
b) Refreshing the page

All exported sheets, such as this one for Samurai:
https://xivgear.app/?page=sl%7C78944845-857b-4a2f-bc04-576f4c6d9dec
Do allow you to access the sim settings, so, you can turn on party buffs, change potion usage etc, but, since it's an exported set, you can neither change the gear set, or refresh the page, as doing so naturally restores the settings.

Additionally, where you have an editable set, it appears that if you change the sim settings for "Use Auto Attacks" and the "Total Time", for any sims using the newish CycleSettings class, your choices for these seem to be overridden and restored to those defined as default in the noted class when the sim loads, so, eg, on refresh.

Here are some repro steps:

  1. Make a new sheet for Dark Knight (DRK), and give it some gear.
  2. Open the sim's sheet by clicking the dps number, observe the settings to be active (Drk first action = TBN)
  3. Access sim settings, turn off potion/use tbn, turn off auto attacks, set fight time to 7 seconds, add a ninja.
  4. Observe number hasn't changed, open the sheet, observe TBN, pot, more than 7 seconds of fighting, no ninja buff.
  5. Refresh the page
  6. Observe the settings page again; Sim Specific & Party Comp should match above, however, Cycle Settings have been restored (DRK's current default values are 510 & Use Auto-Attacks)
  7. Observe the table, no TBN or potion in the case of DRK, but, normal length encounter & autos.

I believe expected behavior is that
step 4 should show you an updated dps number, with a 7 second table with no TBN,
and
step 6 & 7 would retain your choice of no autos and a 7 second fight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant