From ec36ba7cfe1c0dbc7c7fb1db70192130a1e83ae5 Mon Sep 17 00:00:00 2001 From: XP Date: Thu, 27 Jun 2024 16:19:28 -0700 Subject: [PATCH 1/2] Dawntrail buff adjustments --- packages/core/src/sims/buffs.ts | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/packages/core/src/sims/buffs.ts b/packages/core/src/sims/buffs.ts index cdbd6104..b05b2b8f 100644 --- a/packages/core/src/sims/buffs.ts +++ b/packages/core/src/sims/buffs.ts @@ -10,7 +10,7 @@ export const Dokumori = { effects: { dmgIncrease: 0.05, }, - startTime: 3.5, + startTime: 3.40, statusId: 3849 } as const satisfies PartyBuff; @@ -18,13 +18,13 @@ export const Litany = { name: "Battle Litany", saveKey: "Battle Litany", job: "DRG", - duration: 15, + duration: 20, cooldown: 120, selfOnly: false, effects: { critChanceIncrease: 0.10 }, - startTime: 7.5, + startTime: 5.60, statusId: 786 } as const satisfies PartyBuff; @@ -48,7 +48,7 @@ export const Brotherhood = { name: "Brotherhood", saveKey: "Brotherhood", job: "MNK", - duration: 15, + duration: 20, cooldown: 120, selfOnly: false, effects: { @@ -69,7 +69,7 @@ export const ArcaneCircle = { effects: { dmgIncrease: 0.03 }, - startTime: 5, + startTime: 4.59, statusId: 2599 } as const satisfies PartyBuff; @@ -92,13 +92,13 @@ export const SearingLight = { name: "Searing Light", saveKey: "Searing Light", job: "SMN", - duration: 30, + duration: 20, cooldown: 120, selfOnly: false, effects: { dmgIncrease: 0.03 }, - startTime: 1.5, + startTime: 4.7, statusId: 2703 } as const satisfies PartyBuff; @@ -112,7 +112,7 @@ export const Embolden = { effects: { dmgIncrease: 0.05 }, - startTime: 7, + startTime: 6.5, // This is the party member version of this, not the self version statusId: 1297 } as const satisfies PartyBuff; @@ -129,7 +129,7 @@ export const Devilment = { dhitChanceIncrease: 0.20, critChanceIncrease: 0.20 }, - startTime: 7, + startTime: 7.2, statusId: 1825 } as const satisfies PartyBuff; @@ -170,13 +170,13 @@ export const BattleVoice = { name: "Battle Voice", saveKey: "Battle Voice", job: "BRD", - duration: 15, + duration: 20, cooldown: 120, selfOnly: false, effects: { dhitChanceIncrease: 0.20, }, - startTime: 6, + startTime: 6.4, statusId: 141 } as const satisfies PartyBuff; @@ -184,13 +184,13 @@ export const RadiantFinale = { name: "Radiant Finale", saveKey: "Radiant Finale", job: "BRD", - duration: 15, + duration: 20, cooldown: 120, selfOnly: false, effects: { dmgIncrease: 0.06 }, - startTime: 6.7, + startTime: 5.7, statusId: 2964 } as const satisfies PartyBuff; @@ -198,7 +198,7 @@ export const Chain = { name: "Chain", saveKey: "Chain", job: "SCH", - duration: 15, + duration: 20, cooldown: 120, selfOnly: false, effects: { @@ -212,7 +212,7 @@ export const Divination = { name: "Divination", saveKey: "Divination", job: "AST", - duration: 15, + duration: 20, cooldown: 120, selfOnly: false, effects: { @@ -227,7 +227,7 @@ export const AstCard = { saveKey: "Single Target AST Card", job: "AST", duration: 15, - cooldown: 30, + cooldown: 120, selfOnly: false, optional: true, effects: { From c95be9e193e3e9122a156bc0a4e3ae6f0a63fdbf Mon Sep 17 00:00:00 2001 From: XP Date: Thu, 27 Jun 2024 16:22:41 -0700 Subject: [PATCH 2/2] Fix test --- .../src/scripts/test/sims/cycle_processor_tests.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/frontend/src/scripts/test/sims/cycle_processor_tests.ts b/packages/frontend/src/scripts/test/sims/cycle_processor_tests.ts index ec1547f1..b5d48321 100644 --- a/packages/frontend/src/scripts/test/sims/cycle_processor_tests.ts +++ b/packages/frontend/src/scripts/test/sims/cycle_processor_tests.ts @@ -286,7 +286,7 @@ const expectedAbilities: UseResult[] = [ { time: 5.45, name: 'Glare', - damage: 15828.682 + damage: 16652.989 }, { time: 6.93, @@ -361,17 +361,17 @@ const expectedAbilities: UseResult[] = [ { time: 22.48, name: "Glare", - damage: 15828.682 + damage: 17652.168 }, { time: 24.32, name: "Glare", - damage: 15074.935 + damage: 16811.589 }, { time: 25.928, name: "Auto Attack", - damage: 33.301 + damage: 35.299 }, { time: 26.63, @@ -400,7 +400,7 @@ describe('Cycle sim processor', () => { // Run simulation const result = await inst.simulate(set); // Assert correct results - assertClose(result.mainDpsResult, 9896.58, 0.01); + assertClose(result.mainDpsResult, 10040.777, 0.01); assertSimAbilityResults(result, expectedAbilities); }); });