Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate vis.general #24

Open
xiumingzhang opened this issue Oct 11, 2019 · 3 comments
Open

Eliminate vis.general #24

xiumingzhang opened this issue Oct 11, 2019 · 3 comments

Comments

@xiumingzhang
Copy link
Owner

... by renaming it to vis.plot and factoring out those that don't fit into the new name, such as vis.general._save.
@xiumingzhang
Copy link
Owner Author

Another idea: having a new vis.wrap module that contains separate wrappers for pyplot.scatter, pyplot.line, etc. The current universal wrapper is too ambitious, with lots of corner cases.

@xiumingzhang
Copy link
Owner Author

ok, going with the 2nd option, but naming it vis.plot instead.

Start migrating functions from vis.general to vis.plot.

@xiumingzhang xiumingzhang reopened this Sep 29, 2020
xiumingzhang pushed a commit that referenced this issue Sep 29, 2020
To partially address #24
4a0e80f
@xiumingzhang
Copy link
Owner Author

xiumingzhang commented May 10, 2021 •
edited
Loading

Makes more sense to have specialized functions, such as vis.line, vis.scatter, etc. Otherwise, this kind of general wrapper is as hard to use as the original matplotlib API...

@xiumingzhang xiumingzhang changed the title Eliminate vis.general Eliminate vis.general May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xiumingzhang