Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unresolved Symbol #31

Open
ptrstack opened this issue Mar 14, 2022 · 2 comments
Open

Unresolved Symbol #31

ptrstack opened this issue Mar 14, 2022 · 2 comments

Comments

@ptrstack
Copy link

Hello.

I am building with Visual Studio 2022.

I have a problem with an unresolved symbol, in vorbiscomment.

In the function _vorbis_comment_rm_tag (vcomment.c), on line 193, I have replaced strncasecmp with _strnicmp.

I have compiled and the exe has worked. but I don't know if _strnicmp is the correct solution?
@rillian
Copy link
Contributor

rillian commented Mar 15, 2022

The signature looks compatible, and intl/os2compat.h as #define strncasecmp strnicmp so that's probably fine. Not sure how it was working with earlier Visual Studio versions though; maybe there is/was some define to make that function available by default?

@Chocobo1
Copy link
Contributor

This would be resolved by PR #16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rillian @Chocobo1 @ptrstack