Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: improper c std pinning #44

Open
mafemergency opened this issue Sep 27, 2023 · 0 comments
Open

cmake: improper c std pinning #44

mafemergency opened this issue Sep 27, 2023 · 0 comments

Comments

@mafemergency
Copy link

neither gcc nor clang declare the function lrintf in c89 mode while the build script pins this version:
https://github.com/xiph/opusfile/blob/master/CMakeLists.txt#L71
https://c.godbolt.org/z/voebhnGPE

further, a user cannot configure their desired c std as in cmake ... -DCMAKE_C_STANDARD=99 as the target_compile_options command will override this choice

looking at the opus build script i see no mention of std anywhere, and neither does it force-enable warnings that a user can't configure, and i think opusfile should follow that lead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant