Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in ResourceFinder.js #8

Open
angeldavid-monteagudo opened this issue Sep 20, 2018 · 0 comments
Open

Bug in ResourceFinder.js #8

angeldavid-monteagudo opened this issue Sep 20, 2018 · 0 comments

Comments

@angeldavid-monteagudo
Copy link

Hi,

I think I found a bug in https://github.com/xiaoyuze88/isomorphic-pkg-reader/blob/master/lib/ResourceFinder.js when dealing with resource references (around line 347).

In line 358 this.putIntoMap("@" + idStr, data); is called even though data is not set when value_dataType == TYPE_REFERENCE. This results in an extra null every two positions of the resulting array. Moreover, in line 384, for (var value in values) is used to iterate on an array. This should probably be for (var value of values), right now the resulting array is filled with zeros instead of the value at position zero.

I'm afraid I don't have time for a pull request at this moment, sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant