-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add Windows runner for automated testing #132
Comments
#133 provides much of required code changes, but it does currently fail compilation without an error message. |
Of course there's an error message:
And if you had read my comment #112 (comment) carefully, you would know. This does not work with VC compiler, so revert it: e87529f BTW: thank you for finally addressing this. |
Adding the WinGetOpt dependency to actually run the tests on Windows shouldn't be hard, too. Find inspiration here: https://github.com/wo80/vs-arpack/blob/593ae85a26fbccd9e000cc32acdf55def643ea1b/.github/workflows/build.yml#L70-L79 Of course, you'll have to replace SuperLU with the WinGetOpt repo. You might also have to play around with the install prefix. |
The fact that you overlooked the error message is probably due to an abundance of warnings given by the VC compiler. So while you're at it, you might at least disable the pretty useless C4996. Just add Lines 121 to 123 in 8f4f993
|
Thanks for the hint! I will include this, but I want to investigate whether fixing some of the warnings, e.g., the ones with insecure print functions. |
We are testing Ubuntu to build and test SuperLU for every pull request. We should add a Windows runner to detect issues that only occur on Windows.
The text was updated successfully, but these errors were encountered: