Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid logic of param setup #13

Open
gaospecial opened this issue Jun 5, 2024 · 0 comments
Open

Invalid logic of param setup #13

gaospecial opened this issue Jun 5, 2024 · 0 comments

Comments

@gaospecial
Copy link

in https://github.com/xia-lab/OptiLCMS/blob/0737baa52199c96733a5b7e7ff4fc57718f603f0/R/Optimize_params.R#L181C1-L190C10

        param[["ppm"]]<-round(p2$ppm,2);
        param[["noise"]]<-round(p2$noise,2);
        param[["prefilter"]]<-round(p2$prefilter,2);
        param[["value_of_prefilter"]]<-round(p2$value_of_prefilter,2);
        
        if(round(p2$ppm,2) < 1 | round(p2$ppm,2) > 100){
          param[["ppm"]] <- param[["ppm"]]; # Estimation failure, use the default instead !
        } else {
          param[["ppm"]] <- round(p2$ppm,2);
        }

even if 'Estimation failure', no default value is assigned to param[["ppm"]].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant