-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include swift syntax highlighting #8
Comments
Is it something which is hard to do? I would love to work on it, but I need some tips how this should be done What I understand for now is that we use syntect which uses |
No, this should not be hard! The steps are approximately as follows:
|
And: you should be able to test out the syntax by just putting it in xi-mac/xi-editor/syntect-resources and rebuilding xi-mac. |
Thanks! |
Ok then.. I did some research and it looks like Swift Sublime Text packages are outdated. I will refresh my knowledge once in a while in order to support Swift 😄 |
I found this, which has no license: https://github.com/GregoryBL/SwiftSyntax/blob/master/Swift.sublime-syntax |
From the readme it looks like MIT, so that's fine. we'll want to copy the license into a file if we take it on. |
Yes, sorry I was about to clarify that after reading the LICENSE section. I didn't see it before. |
This will also be quite out of date (it's at least two versoins of swift behind?) and it doesn't have metadata, but could be an okay starting point. |
We might be able to update it, but I don't know whether that would affect the licensing? |
Nope, we're free to do whatever we want, we're just expected to include the original license text intact. :) |
Ok, I'm making a PR as we speak... |
Ok, there you go. If that gets merged, I can follow through with a PR on xi-editor, and hopefully xi-mac as well. |
Going to close as it has been a while and I'm not sure if this is relevant anymore. |
No description provided.
The text was updated successfully, but these errors were encountered: