Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance benchmarks #632

Open
4 tasks
nwlandry opened this issue Nov 25, 2024 · 8 comments
Open
4 tasks

Improve performance benchmarks #632

nwlandry opened this issue Nov 25, 2024 · 8 comments
Assignees
Labels
good first issue Good for newcomers improve Make an existing feature better

Comments

@nwlandry
Copy link
Collaborator

The performance benchmarks are implemented here but some things left to do:

  • Change the units of the results to time, not iterations/time
  • Change the chart titles to a more human-readable form similar to Raphtory's
  • Benchmark compare pull requests without storing the output
  • Fix the parameters of the benchmarking method in pytest-benchmark so that it is best practices.
@nwlandry nwlandry added good first issue Good for newcomers improve Make an existing feature better labels Nov 25, 2024
@akskan160103
Copy link

Hey @nwlandry ,

Me and https://github.com/willcollins10 are Computer Science students at the University of Michigan, and we're hoping to use this as our first open source contribution as part of the course we're currently taking. Please feel to reach out with any questions.

Is it also possible for us to claim this issue / be assigned to it so that we can contribute to it?

@nwlandry
Copy link
Collaborator Author

Hi @akskan160103 --- awesome! I will assign you both and let me know if you have any questions!

@nwlandry
Copy link
Collaborator Author

@willcollins10 --- for some reason couldn't add you, but tagging you here.

@nwlandry
Copy link
Collaborator Author

Thanks so much you both!

@akskan160103
Copy link

Of course ! Would it be possible for you to hop on a quick 20 min zoom call with us day after tomorrow in order to understand the project in detail - once we have got our setup done? Sometime later this week would also work but the sooner the better !

@nwlandry
Copy link
Collaborator Author

Feel free to send me an email to schedule something. No guarantees since it's Thanksgiving week, but I'll try!

@akskan160103
Copy link

Hey! I was trying to run the benchmarks locally but noticed a couple of issues:

  1. There’s no asv.conf.json file in the benchmarks directory. Should I create one manually, and if so, is there a recommended config?
  2. I think there’s a typo in the README.md — it refers to requirements/benchmarks.txt, but the actual file is benchmark.txt.

I'm free the whole weekend (anytime between 11 am - 8 pm) so feel free to let me know any time that works for you, and I'll send you an invite. Thanks

@nwlandry
Copy link
Collaborator Author

nwlandry commented Dec 2, 2024

Hi @akskan160103!

  1. we tried using asv for a while, but it seemed impossible to get it to work as a GitHub action. See issue Add performance benchmarks #629.
  2. not sure what you mean. Maybe a permalink to a line would help me out here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improve Make an existing feature better
Projects
None yet
Development

No branches or pull requests

2 participants