Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 #83

Open
sidewaysglance opened this issue Jul 28, 2024 · 2 comments
Open

PHP 8.4 #83

sidewaysglance opened this issue Jul 28, 2024 · 2 comments

Comments

@sidewaysglance
Copy link

Hi,

Just wondering if there's anything interesting coming in PHP 8.4 as far as this wonderful library is concerned?

Cheers

@marcimat
Copy link

marcimat commented Aug 27, 2024

At least, there is a deprecated in PHP 8.4.0alpha4 here

public function __construct(HTMLPurifier_ConfigSchema $schema, HTMLPurifier_PropertyList $parent = null)

Deprecated: HTMLPurifier_HTML5Config::__construct(): Implicitly marking parameter $parent as nullable is deprecated, the explicit nullable type must be used instead in [...]library/HTMLPurifier/HTML5Config.php on line 65
-    public function __construct(HTMLPurifier_ConfigSchema $schema, HTMLPurifier_PropertyList $parent = null)
+    public function __construct(HTMLPurifier_ConfigSchema $schema, ?HTMLPurifier_PropertyList $parent = null)

@xemlock
Copy link
Owner

xemlock commented Aug 31, 2024

Hi! Thanks for pointing that out. I'm planning on making the code PHP 8.4 compatible, as well as use new DOM parsing abilities provided by DOM\HTMLDocument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants