xl2tpd: Close calls when underlying pppd terminate. #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unsure the cause, but we found that upon ppp terminating xl2tpd would only reap the PID, but not actually close the inner call, then at a later stage would issue a kill() for that PID. In our environment with high call turnover this would eventually result in xl2tpd kill()'ing other critical services like mariadb and/or syslog-ng which would upon reloads and rotations have a tendency to re-use PIDs that were previously used by pppd processes. We also believe that this should sort out the problem where IPs wouldn't get cycled and re-used. Closes: xelerance#252 Closes: xelerance#255 Signed-off-by: Jaco Kroon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure the cause, but we found that upon ppp terminating xl2tpd would only reap the PID, but not actually close the inner call, then at a later stage would issue a kill() for that PID.
In our environment with high call turnover this would eventually result in xl2tpd kill()'ing other critical services like mariadb and/or syslog-ng which would upon reloads and rotations have a tendency to re-use PIDs that were previously used by pppd processes.
We also believe that this should sort out the problem where IPs wouldn't get cycled and re-used.
Closes: #252
Closes: #255