Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action value interpretation #180

Open
Chechli opened this issue Aug 12, 2022 · 1 comment
Open

Action value interpretation #180

Chechli opened this issue Aug 12, 2022 · 1 comment

Comments

@Chechli
Copy link

Chechli commented Aug 12, 2022

Dear Xue Bin Peng,

Thank you for sharing your outstanding research.

DeepMimic paper says:

The action a from the policy specifies target orientations for PD controllers at each joint. The policy is queried at 30Hz, and target rientations for spherical joints are represented in axis-angle form, while targets for revolute joints are represented by scalar rotation angles.

In code AxisAngle representation is obtained from ExpMap (it seems to be quite a simple security check), but I cannot find out whether this values are expressed in joints parent frame or root frame, whether this value is absolute or it is just an offset added to skeleton reference pose (T-pose).

Could you give me some more information about target orientation interpretation?

Kind regards

@xbpeng
Copy link
Owner

xbpeng commented Aug 13, 2022

The target joint rotations are specified in the parent's frame, and they represent absolute rotations no offsets to the T-pose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants