-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure out how to resize images correctly #165
Comments
There are definitely a few spots we could resize images, but lots of our images are used multiple places and size based on the size of the screen – like the blog post featured image. It's used in a small size in the card and then a larger one on the blog detail page (really large on larger screens). The addon images are determined by what we get from the mirrors, and the icons are used at basically full size anyway. That mostly leaves the About Kodi card gallery (and the subset used on the main page) could be scaled down. They appear to only be used in that Card format now. |
From my understanding, sharp can still resize these, if you get it setup to get the images via grapdql |
We're going to need someone who actually understands Gatsby Images to do any of this. I've just spent the last hour trying to understand the documentation, and I think I have less understanding than I did an hour ago. I can get things into GraphQL by moving them into I'm not saying someone shouldn't do this, but I don't think we should hold up the site rollout for it. |
I wasn't trying to say that we do this before roleout
Kyle Johnson ***@***.***> schrieb am Sa., 10. Apr. 2021,
21:01:
… We're going to need someone who actually understands Gatsby Images to do
any of this. I've just spent the last hour trying to understand the
documentation, and I think I have *less* understanding than I did an hour
ago. I can get things into GraphQL by moving them into src/images, but
after that I have no idea what to do that gives us any kind of scaled image
(and I've tried). Also, it appears that Netlify doesn't support Gatsby
Images, so unless we are willing to rip that entire thing out and move to
something else (or try and use an outside image processor that works with
Netlify CMS and Gatsby Image), none of the blog stuff can be done with
Gatsby Image.
I'm not saying someone shouldn't do this, but I don't think we should hold
up the site rollout for it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#165 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNLEZB6V43XKQ5YVG27HMTTICOBJANCNFSM42WU7J7Q>
.
|
I'm not sure if we will ever end up doing this, but it feels like we should document it. As lighthouse is basically saying, it would be the single biggest gain to our loading times.
The text was updated successfully, but these errors were encountered: