Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues in the definition of pre_process_binary_cross_entropy, DexiNed-TF2/model.py(P1) #90

Open
DLPerf opened this issue Aug 22, 2021 · 1 comment

Comments

@DLPerf
Copy link

DLPerf commented Aug 22, 2021

Hello, I found a performance issue in the definition of pre_process_binary_cross_entropy, DexiNed-TF2/model.py, tf.cast(y, dtype=tf.float32) will be created repeatedly during program execution, resulting in reduced efficiency. I think it should be created before the loop.

The same issues exist in:

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

@xavysp
Copy link
Owner

xavysp commented Sep 9, 2021

Hi @DLPerf thanks, I'll fix next week because now I am finishing the last version of DexiNed-Pythorch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants