Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

method destroy may delete everything in the table #38

Open
wishper opened this issue Jun 26, 2013 · 0 comments
Open

method destroy may delete everything in the table #38

wishper opened this issue Jun 26, 2013 · 0 comments

Comments

@wishper
Copy link

wishper commented Jun 26, 2013

Hi, thanks for fixing #37
However, the fix changed a bit the behaviour of destroy function
Previously, if record was unsaved, it correctly threw an exception

After #37 , unsaved record have typeof this.id === 'object', so does not fire the exception

However, the deleteRecords function does not find the id, and so it does not create the 'where' clause, executing "delete from "

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant