Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: HyperSHAP #102

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

feat: HyperSHAP #102

wants to merge 33 commits into from

Conversation

Fersoil
Copy link
Collaborator

@Fersoil Fersoil commented Oct 18, 2024

Resolves an issue #98

@codecov Codecov
Copy link

codecov bot commented Oct 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.01558% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/meteors/visualize/shap/plots.py 94.83% 11 Missing ⚠️
src/meteors/shap/shap.py 92.68% 3 Missing ⚠️
src/meteors/shap/explanation.py 96.55% 2 Missing ⚠️
Flag Coverage Δ
unittests 94.52% <95.01%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/meteors/__init__.py 100.00% <100.00%> (ø)
src/meteors/shap/__init__.py 100.00% <100.00%> (ø)
src/meteors/visualize/__init__.py 100.00% <100.00%> (ø)
src/meteors/visualize/attr_visualize.py 98.86% <100.00%> (ø)
src/meteors/visualize/shap/__init__.py 100.00% <100.00%> (ø)
src/meteors/shap/explanation.py 96.55% <96.55%> (ø)
src/meteors/shap/shap.py 92.68% <92.68%> (ø)
src/meteors/visualize/shap/plots.py 94.83% <94.83%> (ø)

@Fersoil
Copy link
Collaborator Author

Fersoil commented Oct 24, 2024 •
edited
Loading

TODO:

  • merge changes from main
  • tests for SHAPExplanation
  • add tests for hypershap
  • beeswarm
  • waterfall
  • dependency plot (fig 1)
  • add dependency to README
  • correct linting
  • docs
  • remove feature names field
  • add aggregation to barplot - inspiration from figure 2

Fersoil and others added 26 commits October 26, 2024 02:20
@Fersoil
Merge branch 'main' into hyper-shap
116adef
simple test for SHAPExplanation
79d3f5e
plots proposition
c823e28
simple validation of explanation object
0088891
Merge branch 'hyper-shap' of github.com:xai4space/meteors into hyper-…
e2205d3 
…shap
adjustments of validation the SHAPExplanation object
ab37cbc
added dependence to README and shap to reference
7f35c8a
mypy interprets the shap folder as a shap package
c85d21f
validations for the visualizations
5b9e831
@Fersoil
Merge branch 'main' into hyper-shap
048dab7
@Fersoil
Merge branch 'main' into hyper-shap
2955f15
fixing the imports after structure change
b43da2a
@Fersoil
Merge branch 'main' into hyper-shap
f4c073a
linting
2422f0b
Merge branch 'hyper-shap' of github.com:xai4space/meteors into hyper-…
d5be6cb 
…shap
draft of visualizations
3103987
args in test fixes
5f2f7b0
another test args fixes
d16947a
@Fersoil
Merge branch 'main' into hyper-shap
f12b377
explanations and feature names - the wrong way
d72ff5e
removed the mess around feature_names
8500d3c
added dependence_plot implementation
ef0d6e9
added tests and fixes
c926d5e
added wavelengths bar plot
049e631
Merge branch 'main' into hyper-shap
1adc1c2
added more detailed tests for shap
16624fb
@Fersoil Fersoil marked this pull request as ready for review November 15, 2024 13:56
@Fersoil Fersoil linked an issue Nov 21, 2024 that may be closed by this pull request
Implement HyperShap #98
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WolodjaZ WolodjaZ Awaiting requested review from WolodjaZ

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement 🔨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement HyperShap
1 participant
@Fersoil