Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pullquote] cite style defined in theme.json not applying #25

Open
justintadlock opened this issue Sep 28, 2024 · 0 comments
Open

[Pullquote] cite style defined in theme.json not applying #25

justintadlock opened this issue Sep 28, 2024 · 0 comments
Assignees
Labels
🐛 Bug I installed this, and now my website is broken. WordPress Issue Whatcha doin' to me WordPress/Gutenberg?

Comments

@justintadlock
Copy link
Contributor

The nested cite styles in theme.json, specifically for color, is broken when using Gutenberg 18.1 (WP 6.6). This PR reduces the specificity of the global styles selector, wrapping everything in :where():

This change causes the Pullquote's cite style nested in .wp-block-pullquote to inherit the color of its parent: https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/pullquote/style.scss

Previously, this was a non-issue because the theme.json-defined color would overrule it. Now, the stylesheet wins out. See:

@justintadlock justintadlock added the WordPress Issue Whatcha doin' to me WordPress/Gutenberg? label Sep 28, 2024
@justintadlock justintadlock self-assigned this Sep 28, 2024
justintadlock added a commit that referenced this issue Sep 28, 2024
This is a stopgap fix until this issue is fixed in WordPress: #25
@justintadlock justintadlock added the 🐛 Bug I installed this, and now my website is broken. label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug I installed this, and now my website is broken. WordPress Issue Whatcha doin' to me WordPress/Gutenberg?
Projects
None yet
Development

No branches or pull requests

1 participant