Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabBar.theme_barTintColor fades tabBar border #148

Open
aarashgoodarzi opened this issue Mar 12, 2021 · 6 comments
Open

tabBar.theme_barTintColor fades tabBar border #148

aarashgoodarzi opened this issue Mar 12, 2021 · 6 comments

Comments

@aarashgoodarzi
Copy link

I'm using this line to change tabBar color :
tabBar.theme_tintColor = ThemeColorPicker.pickerWithUIColors([.white, .black])

when app loads with first theme there's no problem.

bordered

But if app loads with second theme when i change theme to the first, tabBar border will be faded!

no border

any help?

@fukemy
Copy link

fukemy commented Apr 12, 2021

hmm i face same problem here, for rounded border view, did u have any solutions?

@aarashgoodarzi
Copy link
Author

Yes there is a solution. You have to give back the border by yourself, after theme changes. you can observe theme changes as mentioned in SwiftTheme documentation.

@aarashgoodarzi
Copy link
Author

The best solution is to fix the issue by repo maintainers to avoid these hacky solutions :)

@fukemy
Copy link

fukemy commented Apr 12, 2021

hmm i know it, my situation is using round border for "view state", that mean when user online, u can see the green view, then it were inside tableview cell :(, as your guide, i have 2 case

  1. Reload table data -> the most simple case, but may lost current data, then screen will flashed when being reload
  2. Implement notification for each cell :(, that's better, but will take more and more code (check when cell reused, or visible in tableview.....)

So i think better if have simple. way to set theme for border

@aarashgoodarzi
Copy link
Author

aarashgoodarzi commented Apr 12, 2021

Store your data then call reloadData()
Implementing notification for each cell is not a good practice

@wxxsw
Copy link
Owner

wxxsw commented Apr 17, 2021

2021-04-17.8.15.13.mov

Can you provide a demo, or provide steps to reproduce bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants