Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UltimateListCtrl - Fix floor division so floats are not passed to wx.Rect() #2415

Merged
merged 1 commit into from
Jun 12, 2023
Merged

UltimateListCtrl - Fix floor division so floats are not passed to wx.Rect() #2415

merged 1 commit into from
Jun 12, 2023

Conversation

reticulatus
Copy link
Contributor

Fixes #2240

This PR is intended to fix two issues with the UltimateListCtrl related to the use of single division operator returning a float in python >=3.10 which is then passed to wx.Rect.

The issues involve:

  1. Use of ULC_FORMAT_CENTER in the format parameter of an InsertColumn() call.
  2. Use of a checkbox in a column heading.

@swt2c swt2c merged commit 567eb5f into wxWidgets:master Jun 12, 2023
@reticulatus reticulatus deleted the ultimatelistctrl_rect_floats_fixes branch June 12, 2023 13:25
@RobinD42
Copy link
Member

This pull request has been mentioned on Discuss wxPython. There might be relevant details there:

https://discuss.wxpython.org/t/facing-an-error-in-ultimatelistctrl-py-file-for-python-3-10-10/36696/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wxPython 4.2.0 ultimatelistctrl issue with floats in Rect()
3 participants
@reticulatus @RobinD42 @swt2c