Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For API /auth/combinded assert credentialName #1636

Closed
zcgandcomp opened this issue Apr 29, 2024 · 0 comments · Fixed by #1637
Closed

For API /auth/combinded assert credentialName #1636

zcgandcomp opened this issue Apr 29, 2024 · 0 comments · Fixed by #1637
Assignees

Comments

@zcgandcomp
Copy link
Member

If credentialName is used in call API /auth/combined it has to be the same as the the credentialName used to generate the OTP.

we should not remove the parameter from compatibility reason, but.

  • assert that the value in credentialName is the same as used for OTP generation.
  • update the documentation of API - the parameter should not be used or it has to be the same as used for OTP generation.
@jandusil jandusil linked a pull request Apr 30, 2024 that will close this issue
jandusil added a commit that referenced this issue May 6, 2024
* Fix #1636: For API /auth/combinded assert credentialName
 - remove credentialName completely from combined auth
- add migration docs
- update API ref
- remove param from java doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants