From b0d2e02dfe2411872e5e8f92fc92a6420db10bcf Mon Sep 17 00:00:00 2001 From: Lubos Racansky Date: Thu, 5 Dec 2024 11:03:04 +0100 Subject: [PATCH] Fix #1739: Wrong log parameters order in AuthenticationController#authenticateCombined --- .../app/nextstep/controller/AuthenticationController.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/powerauth-nextstep/src/main/java/io/getlime/security/powerauth/app/nextstep/controller/AuthenticationController.java b/powerauth-nextstep/src/main/java/io/getlime/security/powerauth/app/nextstep/controller/AuthenticationController.java index b22146c78..caec8214f 100644 --- a/powerauth-nextstep/src/main/java/io/getlime/security/powerauth/app/nextstep/controller/AuthenticationController.java +++ b/powerauth-nextstep/src/main/java/io/getlime/security/powerauth/app/nextstep/controller/AuthenticationController.java @@ -150,9 +150,10 @@ public ObjectResponse authenticateWithOtp(@Valid @Req }) @PostMapping("combined") public ObjectResponse authenticateCombined(@Valid @RequestBody ObjectRequest request) throws InvalidRequestException, AuthMethodNotFoundException, InvalidConfigurationException, UserNotFoundException, OperationAlreadyFinishedException, OperationAlreadyCanceledException, OperationAlreadyFailedException, CredentialNotFoundException, OperationNotFoundException, OtpNotFoundException, OperationNotValidException, EncryptionException { - logger.info("Received authenticateCombined request, user ID: {}, OTP ID: {}, operation ID: {}", request.getRequestObject().getUserId(), request.getRequestObject().getOperationId(), request.getRequestObject().getOtpId()); - final CombinedAuthenticationResponse response = authenticationService.authenticateCombined(request.getRequestObject()); - logger.info("The authenticateCombined request succeeded, user ID: {}, OTP ID: {}, operation ID: {}, result: {}", request.getRequestObject().getUserId(), request.getRequestObject().getOperationId(), request.getRequestObject().getOtpId(), response.getAuthenticationResult()); + final CombinedAuthenticationRequest requestObject = request.getRequestObject(); + logger.info("Received authenticateCombined request, user ID: {}, OTP ID: {}, operation ID: {}", requestObject.getUserId(), requestObject.getOtpId(), requestObject.getOperationId()); + final CombinedAuthenticationResponse response = authenticationService.authenticateCombined(requestObject); + logger.info("The authenticateCombined request succeeded, user ID: {}, OTP ID: {}, operation ID: {}, result: {}", requestObject.getUserId(), requestObject.getOtpId(), requestObject.getOperationId(), response.getAuthenticationResult()); return new ObjectResponse<>(response); }