Merge pull request #1740 from /issues/1739-logging

Fix #1739: Wrong log parameters order in AuthenticationController#authenticateCombined
wultra · Dec 5, 2024 · 5fb04f1 · 5fb04f1
2 parents 07a721b + b0d2e02
commit 5fb04f1
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/.../java/io/getlime/security/powerauth/app/nextstep/controller/AuthenticationController.java b/.../java/io/getlime/security/powerauth/app/nextstep/controller/AuthenticationController.java
@@ -150,9 +150,10 @@ public ObjectResponse<OtpAuthenticationResponse> authenticateWithOtp(@Valid @Req
     })
     @PostMapping("combined")
     public ObjectResponse<CombinedAuthenticationResponse> authenticateCombined(@Valid @RequestBody ObjectRequest<CombinedAuthenticationRequest> request) throws InvalidRequestException, AuthMethodNotFoundException, InvalidConfigurationException, UserNotFoundException, OperationAlreadyFinishedException, OperationAlreadyCanceledException, OperationAlreadyFailedException, CredentialNotFoundException, OperationNotFoundException, OtpNotFoundException, OperationNotValidException, EncryptionException {
-        logger.info("Received authenticateCombined request, user ID: {}, OTP ID: {}, operation ID: {}", request.getRequestObject().getUserId(), request.getRequestObject().getOperationId(), request.getRequestObject().getOtpId());
-        final CombinedAuthenticationResponse response = authenticationService.authenticateCombined(request.getRequestObject());
-        logger.info("The authenticateCombined request succeeded, user ID: {}, OTP ID: {}, operation ID: {}, result: {}", request.getRequestObject().getUserId(), request.getRequestObject().getOperationId(), request.getRequestObject().getOtpId(), response.getAuthenticationResult());
+        final CombinedAuthenticationRequest requestObject = request.getRequestObject();
+        logger.info("Received authenticateCombined request, user ID: {}, OTP ID: {}, operation ID: {}", requestObject.getUserId(), requestObject.getOtpId(), requestObject.getOperationId());
+        final CombinedAuthenticationResponse response = authenticationService.authenticateCombined(requestObject);
+        logger.info("The authenticateCombined request succeeded, user ID: {}, OTP ID: {}, operation ID: {}, result: {}", requestObject.getUserId(), requestObject.getOtpId(), requestObject.getOperationId(), response.getAuthenticationResult());
         return new ObjectResponse<>(response);
     }