Fix #1803: Ensure the getOperation doesn't change operation status #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanstrobl
requested changes
Dec 13, 2024
...o/getlime/security/powerauth/app/server/service/behavior/tasks/OperationServiceBehavior.java
Outdated
Show resolved
Hide resolved
| @@ -1013,6 +1012,17 @@ private OperationEntity expireOperation(OperationEntity operationEntity, Date cu | |||
| return operationEntity; | |||
| } | |||
|
|
|||
| private void expireOperation(OperationDetailResponse operation, Date currentTimestamp) throws GenericServiceException { | |||
There was a problem hiding this comment.
Let's not duplicate this logic, we can reuse the code below in new private method shared by both expireOperation methods and call it to obtain status.
There was a problem hiding this comment.
This method changes only the response class, not the entity. I suggest to rename it to avoid confusion.
banterCZ
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.